Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tickets/SITCOM-1439 #115

Merged
merged 4 commits into from
Jul 22, 2024
Merged

tickets/SITCOM-1439 #115

merged 4 commits into from
Jul 22, 2024

Conversation

Kelks19
Copy link
Contributor

@Kelks19 Kelks19 commented Jul 12, 2024

Its ready for review. There are two things -

  1. I made a mistake in the first commit message. I will rectify it during squashing commits.
  2. Please check if the page location is ok.

@Kelks19 Kelks19 requested a review from isotuela July 12, 2024 23:40
@isotuela isotuela changed the base branch from main to tickets/SITCOM-1443 July 15, 2024 10:51
@kpenaramirez
Copy link
Contributor

kpenaramirez commented Jul 18, 2024 •
edited
Loading

Hi Kshitija,
I added some comments regarding the overall format and readability. I followed this procedure. Here a couple of points:

  • There is no mention the Stop procedure when doing soak test, I do not know if this is intended.
  • I suggest to keep the EUI screenshot.
  • I suggest adding in a warning maybe that after power cycling Top End Systems the GIS cabinet needs a reset.

kpenaramirez

This comment was marked as duplicate.

Sign in to view

@Kelks19 Kelks19 merged commit 8e20a90 into tickets/SITCOM-1443 Jul 22, 2024
1 of 2 checks passed
@Kelks19 Kelks19 deleted the tickets/SITCOM-1439 branch July 22, 2024 20:30
@Kelks19 Kelks19 mentioned this pull request Jul 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpenaramirez kpenaramirez kpenaramirez left review comments

@carlosgeodesica carlosgeodesica carlosgeodesica left review comments

@isotuela isotuela Awaiting requested review from isotuela

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kelks19 @kpenaramirez @carlosgeodesica