adding AuxTel cabinet content - tickets/SITCOM-1643 #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Garavena89
changed the title
isotuela
requested changes
Oct 15, 2024
There was a problem hiding this comment.
Dear Gonzalo,
Thank you for this. I added three comments:
- Author is Manuel Gomez
- All images must have self-contained descriptive captions for easier navigation.
I will leave the PR in Request Changes to finally approve once you squash all commits into one. Thanks again!
| - If a file cannot include a title (surrounded by ampersands (#)), comment out the title from the template and include a comment explaining why this is implemented (in addition to applying the ``title`` directive). | ||
|
|
||
| .. Include one Primary Author and list of Contributors (comma separated) between the asterisks (*): | ||
| .. |author| replace:: *Ioana Sotuela* |
|
|
||
| .. figure:: ./_static/main_cabinet.jpeg | ||
| :name: main_cabinet | ||
| :scale: 15 % |
There was a problem hiding this comment.
Adding caption to this image too: for instance "AT Main Control Cabinet" or "Outer AT Main Control Cabinet". This way we can link to this image from everywhere in the documentation.
There was a problem hiding this comment.
great idea Ioana, thx
| :name: main_cabinetIN | ||
| :scale: 20 % | ||
|
|
||
| internal components. |
There was a problem hiding this comment.
I think here using a self-contained caption would be useful too "AT Main Control Cabinet contents" or "Inside AT Main Control Cabinet" or "Inner AT Main Control Cabinet". Same for the rest of the cabinets.
isotuela
approved these changes
Oct 21, 2024
isotuela
force-pushed
the
tickets/SITCOM-1643
branch
from
cb6d523
to
e5f42cc
Compare
Garavena89
force-pushed
the
tickets/SITCOM-1643
branch
from
e5f42cc
to
4b8f458
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all!
Just added this ticket about migrating the cabinets content in AuxTel.
I had the idea of adding breath description or links to each component for more details about what they are but I believe not all of them are already uploaded in obs-docs. Also it has a Story points of 1, so I think there is no need for more details. Nevertheless, if all are agree with that I can attempt to add them in corrections.
Cheers!