-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rotator out of range troubleshooting - tickets/SITCOM-1636 #138
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Gonzalo!
Thank you for putting this together.
I have added some general comments for standard conventions (namely, SAL scripts, CSC, errors and scripts configurations) for our repo and also some questions for the Alternative Solution, which I believe it's not complete.
I hope the Checklist for reST https://rubinobs.atlassian.net/wiki/spaces/OOD/pages/39698537/Checklist+for+reST+documentation is useful for future documents. If you have any question, please let me know.
Overview | ||
======== | ||
|
||
When observing during the night, latiss_acquire (Spectroscopic survey) or `track_target_and_take_image` (Imaging survey) scripts failed with a "Rejected: Rotator out of range" error and ATPtg goes into ``FAULT``. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SAL scripts are written using :file:auxtel/track_target_and_take_image.py
using the full name and path of the script. In here both latiss_acquire and track_target_and_take_image should use the standard convention.
Error diagnosis | ||
=============== | ||
|
||
During the imaging or spectroscopic surveys, the scripts latiss_acquire (Spectroscopic survey) or `track_target_and_take_image` (Imaging survey) fail with the following error: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as comment above.
Overview | ||
======== | ||
|
||
When observing during the night, latiss_acquire (Spectroscopic survey) or `track_target_and_take_image` (Imaging survey) scripts failed with a "Rejected: Rotator out of range" error and ATPtg goes into ``FAULT``. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Error message in "Rejected: Rotator out of range" with
.. code-block:: text
=============== | ||
|
||
The interim solution requires recovering the ATPtg back to ``ENABLE`` in the case it went to ``FAULT``, and skiping to the next target in the ATQueue by pressing the :guilabel:`PLAY` buttom. | ||
If this script also fails with the same error, wait three mintues and try again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minutes typo
If this script also fails with the same error, wait three mintues and try again. | ||
|
||
|
||
1. Recover ATPtg from ``FAULT`` state: Transition the ATPtg CSC from LOVE ASummaryState through the states, ``FAULT`` → ``STANDBY`` → ``START`` → ``ENABLE`` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For numbered bullets could you use # as in for instance AuxTel/Troubleshooting/General-Troubleshooting/AuxTel-Elevation-out-of-range.rst?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to do it like this the first time but it seems that when there is something in between (such as a code-block) the numbering resets to 1. That's why I decided to use numbers instead. Don't know if there is a way to solve this issue.
|
||
- az: 90.0 | ||
- el: 60.0 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What to do after this? Keep playing queue. Wouldn't it go to the same area again of the sky and go into out of range again?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, just continue the queue, I added this now, thx.
About your other questions, Mmm...I think I'm not entirely sure what you mean. What you say makes sense to me, but in the instances we've encountered this issue, we've followed the same solution and it has worked. You could be right, but so far, the procedure has been effective.
Gonna go deeper to see if I can find something else about that.
- el: 60.0 | ||
- mag_limit: 8.0 | ||
|
||
1. Then run the external `auxtel/correct_pointing.py` on the same area of the sky using the configuration. Modify *az* and *el* accordingly: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SAL script standard notation and configuration using
.. code-block:: text
:caption: :file:auxtel/correct_pointing.py
default configuration
az: 90.0
el: 60.0
mag_limit: 6.0
mag_range: 4.0
radius: 5
Procedure Steps | ||
=============== | ||
|
||
The interim solution requires recovering the ATPtg back to ``ENABLE`` in the case it went to ``FAULT``, and skiping to the next target in the ATQueue by pressing the :guilabel:`PLAY` buttom. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't the summary state "ENABLED" instead of "ENABLE"?
Procedure Steps | ||
=============== | ||
|
||
The interim solution requires recovering the ATPtg back to ``ENABLE`` in the case it went to ``FAULT``, and skiping to the next target in the ATQueue by pressing the :guilabel:`PLAY` buttom. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CSC are ATPtg in between one *
Post-Condition | ||
============== | ||
|
||
- ATPtg is back to the ``ENABLE`` state. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"ENABLED"
a8a7ec8
to
aeb3a68
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved.
Please review the changes I have made to the formats of SAL scripts and a few minor other issues. Squash the commits into one, before merging.
c333755
to
4c7de24
Compare
Hi folks!
Could you please help me reviewing this ticket for AuxTel about the rotator out of range troubleshooting?
Thanks a lot!