Tickets/sitcom 1359 #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kelks19
requested review from
carlosgeodesica,
Garavena89,
JackieS-NL,
isotuela,
PaulinaLSST and
kaubel
isotuela
reviewed
May 16, 2024
| .. Include one Primary Author and list of Contributors (comma separated) between the asterisks (*): | ||
| .. |author| replace:: Kshitija Kelkar | ||
| .. If there are no contributors, write "none" between the asterisks. Do not remove the substitution. | ||
| .. |contributors| replace:: *List-of-contributors* |
There was a problem hiding this comment.
Please consider adding the reviewers to the list of contributors.
There was a problem hiding this comment.
I think it looks good, great job!
isotuela
approved these changes
May 16, 2024
AuxTel/AuxTel-Non-standard-Operations/AuxTel-EUI-Access/AuxTel-EUI-Access.rst
Outdated
Show resolved
Hide resolved
AuxTel/AuxTel-Non-standard-Operations/AuxTel-EUI-Access/AuxTel-EUI-Access.rst
Outdated
Show resolved
Hide resolved
AuxTel/AuxTel-Non-standard-Operations/AuxTel-EUI-Access/AuxTel-EUI-Access.rst
Outdated
Show resolved
Hide resolved
AuxTel/AuxTel-Non-standard-Operations/AuxTel-EUI-Access/AuxTel-EUI-Access.rst
Show resolved
Hide resolved
AuxTel/AuxTel-Non-standard-Operations/AuxTel-EUI-Access/AuxTel-EUI-Access.rst
Outdated
Show resolved
Hide resolved
AuxTel/AuxTel-Non-standard-Operations/AuxTel-EUI-Access/AuxTel-EUI-Access.rst
Outdated
Show resolved
Hide resolved
AuxTel/AuxTel-Non-standard-Operations/AuxTel-EUI-Access/AuxTel-EUI-Access.rst
Outdated
Show resolved
Hide resolved
AuxTel/AuxTel-Non-standard-Operations/AuxTel-EUI-Access/AuxTel-EUI-Access.rst
Outdated
Show resolved
Hide resolved
AuxTel/AuxTel-Non-standard-Operations/AuxTel-EUI-Access/AuxTel-EUI-Access.rst
Outdated
Show resolved
Hide resolved
Garavena89
approved these changes
May 16, 2024
isotuela
force-pushed
the
tickets/SITCOM-1355
branch
from
6361207
to
9644afd
Compare
isotuela
requested changes
May 20, 2024
There was a problem hiding this comment.
This looks great! Thank you so much! I have added 3 minor comments.
Once done, you can try squashing your commits and rebasing! This video might help:
https://drive.google.com/file/d/1J8m3Bln_O9QIZ4SKJKprW_z2k5ov6tYG/view
Let me know if you have questions.
Thank you!
AuxTel/AuxTel-Non-standard-Operations/AuxTel-EUI-Access/AuxTel-EUI-Access.rst
Outdated
Show resolved
Hide resolved
AuxTel/AuxTel-Non-standard-Operations/AuxTel-EUI-Access/AuxTel-EUI-Access.rst
Outdated
Show resolved
Hide resolved
AuxTel/AuxTel-Non-standard-Operations/AuxTel-EUI-Access/AuxTel-EUI-Access.rst
Show resolved
Hide resolved
Kelks19
force-pushed
the
tickets/SITCOM-1359
branch
2 times, most recently
from
c6affeb
to
96ecf37
Compare
…idual components EUI wepages (Dome, spectrograph, top box control and telescope MCS+pneumatics)
Kelks19
force-pushed
the
tickets/SITCOM-1359
branch
from
96ecf37
to
5351eb8
Compare
PaulinaLSST
reviewed
Jun 7, 2024
|
|
||
| .. _Informative-Document-Main-Information-Section: | ||
|
|
||
| This document explains how to access all the components of *AuxTel EUI*-- for ATMCS, ATSPectrograph and ATDome-- through a remote desktop. |
There was a problem hiding this comment.
It would be helpful to have acronyms written out the first time they are mentioned to provide clarity and understanding. For example, in the AuxTel EUI, while "AuxTel" is well-known and frequently appears, "EUI" is not as commonly recognized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a page about AuxTel EUI access in the Non-standard procedures