Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve repository set up #4

Merged
merged 4 commits into from
Aug 27, 2024
Merged

Improve repository set up #4

merged 4 commits into from
Aug 27, 2024

Conversation

jonathansick
Copy link
Contributor

This PR is intended to help get the repository ready for Times Square.

  • Fix a YAML formatting issue in logrep_proto_1.yaml
  • Add a pre-commit configurartion that validates the YAML and also strips outputs from comitted notebooks, which is generally a good practice for Times Square
  • Adds a GitHub Actions workflow that runs this linting step.

The `|` is YAML syntax, so these strings need to be quoted.
- The YAML checker validates the Times Square configuration files
- nbstripout ensures notebooks are committed without their outputs
This ensures that PRs are validated with pre-commit.
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@pothiers pothiers merged commit 198dd93 into develop Aug 27, 2024
3 checks passed
@pothiers pothiers deleted the u/jonathansick/fix-setup branch August 27, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants