DM-39900: Develop improved metrics for completeness based on injected sources #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrunoSanchez
force-pushed
the
tickets/DM-39900
branch
2 times, most recently
from
506753d
to
0fc72db
Compare
isullivan
reviewed
Sep 2, 2024
python/lsst/analysis/tools/tasks/diaFakesDetectorVisitAnalysis.py
Outdated
Show resolved
Hide resolved
python/lsst/analysis/tools/tasks/diaFakesDetectorVisitAnalysis.py
Outdated
Show resolved
Hide resolved
python/lsst/analysis/tools/tasks/diaFakesDetectorVisitAnalysis.py
Outdated
Show resolved
Hide resolved
| doc="CcdVisit-based Matched fake to load from the butler", | ||
| name="{fakesType}{coaddName}Diff_matchDiaSrc", | ||
| storageClass="DataFrame", | ||
| deferLoad=True, |
There was a problem hiding this comment.
Not sure why this is needed. But my test runs conclude that removing this makes the pipeline fail. Maybe it's a good topic for standup.
| doc="CcdVisit-based Matched fake to load from the butler", | ||
| name="{fakesType}{coaddName}Diff_matchDiaSourceTable", | ||
| storageClass="DataFrame", | ||
| deferLoad=True, |
python/lsst/analysis/tools/tasks/diaFakesDetectorVisitAnalysis.py
Outdated
Show resolved
Hide resolved
isullivan
approved these changes
Sep 4, 2024
BrunoSanchez
force-pushed
the
tickets/DM-39900
branch
from
0fc72db
to
2b85630
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding metrics that calculate fraction of fakes found.
Next iteration is to provide a completeness per bandpass in magnitude space.