DM-43338: Add a debugPSF pipeline and associated plots #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sr525
force-pushed
the
tickets/DM-43338
branch
3 times, most recently
from
7a01a1a
to
ba8d068
Compare
jmeyers314
requested changes
Jul 23, 2024
pipelines/debugPSF.yaml
Outdated
| config: | ||
| connections.outputName: debugCoaddPsf | ||
| # set plots to run | ||
| atools.ap12PsfSky: Ap12PsfSkyPlot # photometry.py |
There was a problem hiding this comment.
[comments] too few spaces before comment
Should probably make the linter happy if it's going to be running all the time...
pipelines/debugPSF.yaml
Outdated
| config: | ||
| connections.outputName: debugVisitPsf | ||
| atools.e1DiffScatter: E1DiffScatterVisit # shapes.py | ||
| atools.e2Diffscatter: E2DiffScatterVisit # shapes.py |
There was a problem hiding this comment.
Suggested change
| atools.e2Diffscatter: E2DiffScatterVisit # shapes.py | |
| atools.e2DiffScatter: E2DiffScatterVisit # shapes.py |
| self.process.calculateActions.stars.lowSNSelector.fluxType = "psfFlux" | ||
| self.process.calculateActions.stars.fluxType = "psfFlux" | ||
|
|
||
| self.process.filterActions.yStars = LoadVector(vectorKey="e1Diff") |
There was a problem hiding this comment.
Is this necessary? Can we use something other than e1Diff as a place-holder that must be overridden by subclasses?
There was a problem hiding this comment.
Good catch, I think this might be the same problem that made the plots look the same.
| """ | ||
|
|
||
| def setDefaults(self): | ||
| super().setDefaults() |
There was a problem hiding this comment.
Suggested change
| super().setDefaults() | |
| super().setDefaults() | |
| self.process.filterActions.yStars = LoadVector(vectorKey="e2Diff") |
I think you need something like this?
| self.process.filterActions.yStars = DownselectVector( | ||
| vectorKey="e1Diff", selector=VectorSelector(vectorKey="starSelector") | ||
| ) | ||
| self.applyContext(VisitContext) |
There was a problem hiding this comment.
Suggested change
| self.applyContext(VisitContext) | |
| self.applyContext(VisitContext) | |
| self.process.filterActions.yStars = LoadVector(vectorKey="fracDiff") |
Probably need this?
| super().setDefaults() | ||
| self.applyContext(CoaddContext) | ||
| self.process.filterActions.yStars = LoadVector(vectorKey="e1Diff") | ||
| self.produce.plot.yAxisLabel = "Ellipticty residuals (e1 - e1_PSF)" |
There was a problem hiding this comment.
Suggested change
| self.produce.plot.yAxisLabel = "Ellipticty residuals (e1 - e1_PSF)" | |
| self.produce.plot.yAxisLabel = "Ellipticity residuals (e1 - e1_PSF)" |
| self.produce.plot.yAxisLabel = "Ellipticty residuals (e2 - e2_PSF)" | ||
| self.produce.plot.zAxisLabel = "E2 Diff" | ||
| self.produce.plot.plotName = "E2 Diff Sky" | ||
| self.applyContext(CoaddContext) |
| @@ -222,3 +506,271 @@ def setDefaults(self): | |||
| self.process.buildActions.statMask = SnSelector() | |||
| self.process.buildActions.statMask.threshold = 20 | |||
| self.process.buildActions.statMask.fluxType = "psfFlux" | |||
|
|
|||
|
|
|||
| class BaseElips(AnalysisTool): | |||
There was a problem hiding this comment.
Is this used anywhere? Can we delete this class? (and associated entry in __all__)?
sr525
force-pushed
the
tickets/DM-43338
branch
5 times, most recently
from
6e912e4
to
ef465f0
Compare
jmeyers314
reviewed
Aug 12, 2024
| class E1FocalPlane(EFocalPlane): | ||
| """A focal plane plot of E1.""" | ||
|
|
||
| parameterizedBand: bool = False |
There was a problem hiding this comment.
Can this be factored out to the base class? (And similar in E?SkyVisit?)
sr525
force-pushed
the
tickets/DM-43338
branch
from
ef465f0
to
6e7ee9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.