Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-36457: Use globs instead of regexes for dataset type patterns #279

Merged
merged 1 commit into from
Aug 9, 2024
Merged

DM-36457: Use globs instead of regexes for dataset type patterns #279

merged 1 commit into from
Aug 9, 2024

Conversation

timj
Copy link
Member

@timj timj commented Aug 9, 2024

queryDatasetTypes no longer supports regexes.

@timj
Use globs instead of regexes for dataset type patterns
cf652ff 
queryDatasetTypes no longer supports regexes.
@timj timj requested a review from TallJimbo August 9, 2024 16:07
TallJimbo
TallJimbo approved these changes Aug 9, 2024
View reviewed changes
Copy link
Member

@TallJimbo TallJimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Figures that it would be code that I wrote that would be using regexes here.

@timj timj merged commit 5c219ae into main Aug 9, 2024
8 checks passed
@timj timj deleted the tickets/DM-36457 branch August 9, 2024 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TallJimbo TallJimbo TallJimbo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timj @TallJimbo