Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-46061: Add Metrics to calibrate task metadata #282

Merged
merged 3 commits into from
Oct 6, 2024
Merged

DM-46061: Add Metrics to calibrate task metadata #282

merged 3 commits into from
Oct 6, 2024

Conversation

jrmullaney
Copy link
Contributor

No description provided.

@jrmullaney jrmullaney force-pushed the tickets/DM-46061 branch 6 times, most recently from 0fa1df6 to dc239ee Compare September 12, 2024 10:05
@jrmullaney jrmullaney force-pushed the tickets/DM-46061 branch 5 times, most recently from 33af081 to 078b549 Compare October 1, 2024 17:24
@jrmullaney jrmullaney changed the title Tickets/dm 46061 tickets/DM-46061 Oct 1, 2024
@jrmullaney jrmullaney changed the title tickets/DM-46061 DM-46061: Add Metrics to calibrate task metadata Oct 1, 2024
@jrmullaney jrmullaney marked this pull request as ready for review October 1, 2024 17:57
@jrmullaney jrmullaney force-pushed the tickets/DM-46061 branch 2 times, most recently from 1a0709c to b8b447a Compare October 1, 2024 22:37
@jrmullaney jrmullaney requested review from isullivan and removed request for ctslater October 2, 2024 19:42
isullivan
isullivan approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@isullivan isullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We should try to replace both metadataExposureDetectorAnalysis.py and diffimTaskDetectorVisitMetricsAnalysis.py with calls to your new generic class. Those can be done on new tickets, though.

python/lsst/analysis/tools/tasks/metadataAnalysis.py Show resolved Hide resolved
pipelines/calexpMetrics.yaml Outdated Show resolved Hide resolved
python/lsst/analysis/tools/tasks/metadataAnalysis.py Outdated Show resolved Hide resolved
@jrmullaney jrmullaney merged commit a32ea48 into main Oct 6, 2024
8 checks passed
@jrmullaney jrmullaney deleted the tickets/DM-46061 branch October 6, 2024 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isullivan isullivan isullivan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jrmullaney @isullivan