DM-45325: Move CTI simulation classes to lsst.ip.isr.deferredCharge #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erykoff
reviewed
Aug 22, 2024
There was a problem hiding this comment.
This is a little bit tricky, but we need to deprecate the old imports in case somebody has been lifting OverscanModel from here. See https://developer.lsst.io/stack/deprecating-interfaces.html in general, and see https://github.com/lsst/pipe_tasks/blob/c100eb463524ac2dc860a101d48d552f65cd4135/python/lsst/pipe/tasks/assembleCoadd.py#L32 for a possible pattern to lift the imports and warn if somebody imports from the old location. You also need to file a ticket to remove the deprecated usage and add that as a TODO.
Alex-Broughton
force-pushed
the
tickets/DM-45325
branch
from
f0e16d3
to
88b57a4
Compare
erykoff
reviewed
Aug 23, 2024
Alex-Broughton
force-pushed
the
tickets/DM-45325
branch
from
88b57a4
to
a2a542a
Compare
erykoff
requested changes
Aug 27, 2024
Alex-Broughton
force-pushed
the
tickets/DM-45325
branch
from
a2a542a
to
1863454
Compare
erykoff
approved these changes
Sep 19, 2024
Alex-Broughton
force-pushed
the
tickets/DM-45325
branch
from
1863454
to
782302c
Compare
erykoff
approved these changes
Sep 24, 2024
Alex-Broughton
force-pushed
the
tickets/DM-45325
branch
from
782302c
to
51a0e00
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.