Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-46845 Stop support for execution butler for remote job submission #73

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

zhaoyuyoung
Copy link
Contributor

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.87%. Comparing base (645c201) to head (0121dd5).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #73   +/-   ##
=======================================
  Coverage   28.87%   28.87%           
=======================================
  Files           9        9           
  Lines         710      710           
  Branches      128      113   -15     
=======================================
  Hits          205      205           
- Misses        495      496    +1     
+ Partials       10        9    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@MichelleGower MichelleGower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A comment about the changes file. Also, shouldn't the executionButler lines (and comments) be removed from the config/*.yaml files? After addressing these things, merge is approved.

@@ -0,0 +1 @@
Stop support for execution butler for remote job submission
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

towncrier notes should be in past tense (e.g., Removed or Stopped)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review. I've addressed this one and the configuration yamls.

@zhaoyuyoung zhaoyuyoung merged commit 00d6399 into main Oct 15, 2024
14 checks passed
@zhaoyuyoung zhaoyuyoung deleted the tickets/DM-46845 branch October 15, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants