Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-40303: Minor clean ups for pydantic v2 #255

Merged
merged 13 commits into from
Aug 5, 2023
Merged

DM-40303: Minor clean ups for pydantic v2 #255

merged 13 commits into from
Aug 5, 2023

Conversation

timj
Copy link
Member

@timj timj commented Aug 4, 2023

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@timj timj changed the title DM-40303: Minor clean ups DM-40303: Minor clean ups for pydantic v2 Aug 4, 2023
@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Patch coverage: 71.05% and project coverage change: +0.05% 🎉

Comparison is base (7c1dbd7) 85.35% compared to head (2e6c9e3) 85.40%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #255      +/-   ##
==========================================
+ Coverage   85.35%   85.40%   +0.05%     
==========================================
  Files          47       47              
  Lines        4260     4262       +2     
  Branches      735      744       +9     
==========================================
+ Hits         3636     3640       +4     
+ Misses        468      465       -3     
- Partials      156      157       +1     
Files Changed Coverage Δ
python/lsst/ctrl/mpexec/cli/opt/options.py 87.32% <ø> (ø)
python/lsst/ctrl/mpexec/mpGraphExecutor.py 85.99% <0.00%> (ø)
python/lsst/ctrl/mpexec/showInfo.py 74.73% <0.00%> (ø)
python/lsst/ctrl/mpexec/cmdLineFwk.py 63.01% <66.66%> (+0.44%) ⬆️
python/lsst/ctrl/mpexec/reports.py 91.42% <66.66%> (-5.45%) ⬇️
python/lsst/ctrl/mpexec/cli/utils.py 93.87% <100.00%> (+3.87%) ⬆️
python/lsst/ctrl/mpexec/execFixupDataId.py 90.24% <100.00%> (ø)
python/lsst/ctrl/mpexec/log_capture.py 75.00% <100.00%> (+1.66%) ⬆️
tests/test_cmdLineFwk.py 98.34% <100.00%> (ø)
tests/test_reports.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@timj timj force-pushed the tickets/DM-40303 branch 2 times, most recently from a679294 to 027c659 Compare August 4, 2023 20:17
Copy link
Collaborator

@andy-slac andy-slac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@timj timj merged commit 9b9569d into main Aug 5, 2023
13 of 14 checks passed
@timj timj deleted the tickets/DM-40303 branch August 5, 2023 03:11
@timj timj mentioned this pull request Sep 21, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants