DM-38041: delegate to new pre-exec-init implementations in pipe_base #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the exception types raised (to be more consistent with what saveInitOutputs already raised), but these weren't really recoverable errors so this shouldn't break anything.
This again changes the exception types raised (to be more consistent with what saveInitOutputs already raised), but these weren't really recoverable errors so this shouldn't break anything.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #308 +/- ##
==========================================
+ Coverage 89.00% 89.57% +0.56%
==========================================
Files 50 50
Lines 4439 4317 -122
Branches 733 693 -40
==========================================
- Hits 3951 3867 -84
+ Misses 347 325 -22
+ Partials 141 125 -16 ☔ View full report in Codecov by Sentry. |
TallJimbo
force-pushed
the
tickets/DM-38041
branch
from
8606e01
to
3226412
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on lsst/pipe_base#444
Checklist
doc/changes(in pipe_base)