Merge pull request #142 from lsst/tickets/DM-44934

DM-44934: Remove xy axes limit configs for WholeSkyPlot.
lsst · Aug 23, 2024 · aaa893a · aaa893a
2 parents b3e345f + e824985
commit aaa893a
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 20 deletions.
diff --git a/pipelines/HSC/DRP-RC2.yaml b/pipelines/HSC/DRP-RC2.yaml
@@ -75,8 +75,6 @@ tasks:
       connections.inputName: "matchedVisitCore_metricsTable"
       connections.outputName: "matchedVisitCore_wholeSky"
       atools.wholeSkyMetric: WholeSkyPlotTool
-      atools.wholeSkyMetric.xLimits: [145.0, 340.0]
-      atools.wholeSkyMetric.yLimits: [-5.0, 10.0]
       atools.wholeSkyMetric.bands: ["g", "r", "i", "z", "y"]
       atools.wholeSkyMetric.plotKeys: []
       atools.wholeSkyMetric.keysWithBand: parameters.matchedVisitCoreKeysWithBand
@@ -86,8 +84,6 @@ tasks:
     class: lsst.analysis.tools.tasks.WholeSkyAnalysisTask
     config:
       atools.wholeSkyMetric: WholeSkyPlotTool
-      atools.wholeSkyMetric.xLimits: [145.0, 340.0]
-      atools.wholeSkyMetric.yLimits: [-5.0, 10.0]
       atools.wholeSkyMetric.bands: ["g", "r", "i", "z", "y"]
       atools.wholeSkyMetric.plotKeys: parameters.objectTableCorePlotKeys
       atools.wholeSkyMetric.keysWithBand: parameters.objectTableCoreKeysWithBand
@@ -99,8 +95,6 @@ tasks:
       connections.inputName: "objectTable_tract_gaia_dr3_20230707_match_metricsTable"
       connections.outputName: "objectTableCoreRefCatMatch_wholeSky"
       atools.wholeSkyMetric: WholeSkyPlotTool
-      atools.wholeSkyMetric.xLimits: [145.0, 340.0]
-      atools.wholeSkyMetric.yLimits: [-5.0, 10.0]
       atools.wholeSkyMetric.bands: ["g", "r", "i", "z", "y"]
       atools.wholeSkyMetric.plotKeys: []
       atools.wholeSkyMetric.keysWithBand: parameters.objectTableCoreRefCatMatchKeysWithBand

diff --git a/pipelines/HSC/DRP-RC2_subset.yaml b/pipelines/HSC/DRP-RC2_subset.yaml
@@ -29,8 +29,6 @@ tasks:
       connections.inputName: "matchedVisitCore_metricsTable"
       connections.outputName: "matchedVisitCore_wholeSky"
       atools.wholeSkyMetric: WholeSkyPlotTool
-      atools.wholeSkyMetric.xLimits: [125.0, 175.0]
-      atools.wholeSkyMetric.yLimits: [-5.0, 10.0]
       atools.wholeSkyMetric.bands: ["g", "r", "i", "z", "y"]
       atools.wholeSkyMetric.plotKeys: []
       atools.wholeSkyMetric.keysWithBand: parameters.matchedVisitCoreKeysWithBand
@@ -152,8 +150,6 @@ tasks:
     class: lsst.analysis.tools.tasks.WholeSkyAnalysisTask
     config:
       atools.wholeSkyMetric: WholeSkyPlotTool
-      atools.wholeSkyMetric.xLimits: [125.0, 175.0]
-      atools.wholeSkyMetric.yLimits: [-5.0, 10.0]
       atools.wholeSkyMetric.bands: ["g", "r", "i", "z", "y"]
       atools.wholeSkyMetric.plotKeys: parameters.objectTableCorePlotKeys
       atools.wholeSkyMetric.keysWithBand: parameters.objectTableCoreKeysWithBand
@@ -165,8 +161,6 @@ tasks:
       connections.inputName: "objectTable_tract_gaia_dr3_20230707_match_metricsTable"
       connections.outputName: "objectTableCoreRefCatMatch_wholeSky"
       atools.wholeSkyMetric: WholeSkyPlotTool
-      atools.wholeSkyMetric.xLimits: [125.0, 175.0]
-      atools.wholeSkyMetric.yLimits: [-5.0, 10.0]
       atools.wholeSkyMetric.bands: ["g", "r", "i", "z", "y"]
       atools.wholeSkyMetric.plotKeys: []
       atools.wholeSkyMetric.keysWithBand: parameters.objectTableCoreRefCatMatchKeysWithBand

diff --git a/pipelines/HSC/DRP-ci_hsc.yaml b/pipelines/HSC/DRP-ci_hsc.yaml
@@ -50,14 +50,18 @@ tasks:
     class: lsst.pipe.tasks.isolatedStarAssociation.IsolatedStarAssociationTask
     config:
       band_order: ['i', 'r']
+  makeMetricTableObjectTableCoreRefCatMatch:
+    class: lsst.analysis.tools.tasks.MakeMetricTableTask
+    config:
+      connections.metricBundleName: "objectTable_tract_gaia_dr3_20230707_match_astrom_metrics"
+      python: |
+        from lsst.analysis.tools.atools import *
   matchedVisitCoreWholeSkyPlot:
     class: lsst.analysis.tools.tasks.WholeSkyAnalysisTask
     config:
       connections.inputName: "matchedVisitCore_metricsTable"
       connections.outputName: "matchedVisitCore_wholeSky"
       atools.wholeSkyMetric: WholeSkyPlotTool
-      atools.wholeSkyMetric.xLimits: [295.0, 345.0]
-      atools.wholeSkyMetric.yLimits: [-7.5, 7.5]
       atools.wholeSkyMetric.bands: ["r", "i"]
       atools.wholeSkyMetric.plotKeys: []
       atools.wholeSkyMetric.keysWithBand: parameters.matchedVisitCoreKeysWithBand
@@ -67,13 +71,22 @@ tasks:
     class: lsst.analysis.tools.tasks.WholeSkyAnalysisTask
     config:
       atools.wholeSkyMetric: WholeSkyPlotTool
-      atools.wholeSkyMetric.xLimits: [295.0, 345.0]
-      atools.wholeSkyMetric.yLimits: [-7.5, 7.5]
       atools.wholeSkyMetric.bands: ["r", "i"]
       atools.wholeSkyMetric.plotKeys: parameters.objectTableCorePlotKeys
       atools.wholeSkyMetric.keysWithBand: parameters.objectTableCoreKeysWithBand
       python: |
         from lsst.analysis.tools.atools import *
+  objectTableCoreRefCatMatchWholeSkyPlot:
+    class: lsst.analysis.tools.tasks.WholeSkyAnalysisTask
+    config:
+      connections.inputName: "objectTable_tract_gaia_dr3_20230707_match_astrom_metricsTable"
+      connections.outputName: "objectTableCoreRefCatMatch_wholeSky"
+      atools.wholeSkyMetric: WholeSkyPlotTool
+      atools.wholeSkyMetric.bands: ["r", "i"]
+      atools.wholeSkyMetric.plotKeys: []
+      atools.wholeSkyMetric.keysWithBand: parameters.objectTableCoreRefCatMatchKeysWithBand
+      python: |
+        from lsst.analysis.tools.atools import *
 
 subsets:
   analysis_tools:
@@ -88,8 +101,10 @@ subsets:
       - catalogMatchTract
       - makeMetricTableMatchedVisitCore
       - makeMetricTableObjectTableCore
+      - makeMetricTableObjectTableCoreRefCatMatch
       - matchedVisitCoreWholeSkyPlot
       - objectTableCoreWholeSkyPlot
+      - objectTableCoreRefCatMatchWholeSkyPlot
       - photometricCatalogMatch
       - photometricRefCatObjectTract
       - plotPropertyMapTract

diff --git a/pipelines/_ingredients/LSSTComCamSim/DRP.yaml b/pipelines/_ingredients/LSSTComCamSim/DRP.yaml
@@ -100,8 +100,6 @@ tasks:
       connections.inputName: "matchedVisitCore_metricsTable"
       connections.outputName: "matchedVisitCore_wholeSky"
       atools.wholeSkyMetric: WholeSkyPlotTool
-      atools.wholeSkyMetric.xLimits: [120.0, 305.0]
-      atools.wholeSkyMetric.yLimits: [-55.0, 10.0]
       atools.wholeSkyMetric.bands: ["g", "r", "i"]
       atools.wholeSkyMetric.plotKeys: []
       atools.wholeSkyMetric.keysWithBand: parameters.matchedVisitCoreKeysWithBand
@@ -111,8 +109,6 @@ tasks:
     class: lsst.analysis.tools.tasks.WholeSkyAnalysisTask
     config:
       atools.wholeSkyMetric: WholeSkyPlotTool
-      atools.wholeSkyMetric.xLimits: [120.0, 305.0]
-      atools.wholeSkyMetric.yLimits: [-55.0, 10.0]
       atools.wholeSkyMetric.bands: ["g", "r", "i"]
       atools.wholeSkyMetric.plotKeys: [
         "wPerpPSFP_wPerp_psfFlux_median",