DM-44232: Replace makeWarp with makeDirectWarp #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arunkannawadi
force-pushed
the
tickets/DM-44232
branch
2 times, most recently
from
d758d61 to
b986a17
Compare
arunkannawadi
force-pushed
the
tickets/DM-44232
branch
from
0e0f0cc to
d10243a
Compare
arunkannawadi
force-pushed
the
tickets/DM-44232
branch
from
d10243a to
ad50a42
Compare
arunkannawadi
force-pushed
the
tickets/DM-44232
branch
from
5bbbe27 to
5fb9330
Compare
arunkannawadi
force-pushed
the
tickets/DM-44232
branch
from
5fb9330 to
988bab9
Compare
arunkannawadi
commented
Aug 1, 2024
| @@ -199,7 +202,8 @@ subsets: | |||
| subset: | |||
| - selectGoodSeeingVisits | |||
| - selectDeepCoaddVisits | |||
| - makeWarp | |||
| - makeDirectWarp | |||
| - makePsfMatchedWarp | |||
There was a problem hiding this comment.
@leeskelvin I haven't tested that these changes that I am making to DRP pipeline are okay on DECam beyond CI passing. I've done more detailed tests in DM-45426 on HSC and DC2 datasets. Is there a coadd dataId I should run this on on DECam data to make sure that the coadds are largely the same even after I swap out the warping tasks?
makeDirectWarp and makePsfMatchedWarp.
arunkannawadi
force-pushed
the
tickets/DM-44232
branch
from
988bab9 to
ed9b019
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and makePsfMatchedWarp.