DM-45192: Reconfigure RA for real ComCam #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yalsayyad
approved these changes
Aug 6, 2024
| nVisitsMin: 12 | ||
| # For simulation 2 there are 60 visits per region | ||
| # between 60399.362 and 60402.419. | ||
| minMJD: 60399.362 |
There was a problem hiding this comment.
Delete OR-specific minMJD and maxMJD overrides.
| class: lsst.analysis.tools.tasks.photometricCatalogMatch.PhotometricCatalogMatchVisitTask | ||
| config: | ||
| extraColumns: ["x", "y", "ap09Flux", "ap09FluxErr"] | ||
| connections.refCatalog: uw_stars_20240524 |
There was a problem hiding this comment.
All these refcats will need to change. You can delete any lines with "uw_stars" in them or leave them, but they'll need to be revisited on the next ticket.
There was a problem hiding this comment.
Ah yes, good point, thanks. I've just done a find & replace on all those to change them to gaia_dr3_20230707, because that's at least a little less wrong - I think that's probably right for the astrometry bits, and means that we should then only need to change the photometry parts. Hopefully that's better than leaving them, anyway.
mfisherlevine
force-pushed
the
tickets/DM-45192
branch
from
4899473 to
d0e012a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.