Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-45506: Revise pipeline YAMLs to include analyzeAmpOffsetMetadata with properly configured doAmpOffset and doApplyAmpOffset options #144

Merged
merged 6 commits into from
Aug 6, 2024

Conversation

enourbakhsh
Copy link
Contributor

No description provided.

@enourbakhsh enourbakhsh changed the title DM-45506: Enable analyzeAmpOffsetMetadata in various pipeline YAMLs with doAmpOffset and doApplyAmpOffset adjustments DM-45506: Revise pipeline YAMLs to include analyzeAmpOffsetMetadata with properly configured doAmpOffset and doApplyAmpOffset options Aug 6, 2024
Comment on lines +34 to +37
# Although we don't have to apply the amp offset corrections, we do want
# to compute them for analyzeAmpOffsetMetadata to report on as metrics.
doAmpOffset: true
ampOffset.doApplyAmpOffset: false
Copy link
Contributor Author

@enourbakhsh enourbakhsh Aug 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needed to add this here since this YAML file does not import _ingredients/DRP-full.yaml.

Copy link

@czwa czwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confused myself for a moment, but I think this is all fine.

@enourbakhsh enourbakhsh merged commit f745346 into main Aug 6, 2024
3 checks passed
@enourbakhsh enourbakhsh deleted the tickets/DM-45506 branch August 6, 2024 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants