DM-45426: Account for warps from make_direct_warp are bigger #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arunkannawadi
force-pushed
the
tickets/DM-45426
branch
3 times, most recently
from
b835ff9 to
debecab
Compare
TallJimbo
approved these changes
Aug 1, 2024
| @@ -392,6 +392,9 @@ def runQuantum(self, butlerQC, inputRefs, outputRefs): | |||
| skyMap, tractId=outputDataId["tract"], patchId=outputDataId["patch"] | |||
| ) | |||
|
|
|||
| # Attach the bounding box of the coadd this task is producing. | |||
| self.coadd_bbox = inputData["skyInfo"].bbox | |||
There was a problem hiding this comment.
I'm not a fan of putting per-quantum state on the task instance. Better to pass this around as another argument if it's needed in multiple methods.
arunkannawadi
force-pushed
the
tickets/DM-45426
branch
from
f881e97 to
77498c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.