Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-43077: Convert all tasks to use CalibrateImageTask outputs #73

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

DM-43077: Convert all tasks to use CalibrateImageTask outputs #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
884d22f
Switch to calibrateImage outputs
parejkoj Jul 30, 2024
f6ec4cd
Remove STREAK from forcedPhotCoadd
parejkoj Sep 17, 2024
6b90a6e
Set reprocessVisitImage default to not use skyCorr
yalsayyad Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions python/lsst/drp/tasks/forcedPhotCoadd.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,14 +159,15 @@ def setDefaults(self):
"SENSOR_EDGE",
"REJECTED",
"INEXACT_PSF",
"STREAK",
# TODO DM-44658 and DM-45980: don't have STREAK propagated yet.
# "STREAK",
]
self.measurement.plugins["base_PixelFlags"].masksFpCenter = [
"CLIPPED",
"SENSOR_EDGE",
"REJECTED",
"INEXACT_PSF",
"STREAK",
# "STREAK",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although only a few lines away from the prior TODO, this probably also needs a TODO inline comment to ensure that it isn't missed when the time comes to uncomment this.

]


Expand Down
2 changes: 1 addition & 1 deletion python/lsst/drp/tasks/reprocess_visit_image.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ class ReprocessVisitImageConfig(

do_use_sky_corr = pexConfig.Field(
dtype=bool,
default=True,
default=False,
doc="Include the skyCorr input for background subtraction?",
)
snap_combine = pexConfig.ConfigurableField(
Expand Down
4 changes: 2 additions & 2 deletions python/lsst/drp/tasks/update_visit_summary.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,7 @@ class UpdateVisitSummaryConnections(
"Per-detector images to obtain image, mask, and variance from "
"(embedded summary stats and other components are ignored)."
),
name="calexp",
name="initial_pvi",
dimensions=("instrument", "detector", "visit"),
storageClass="ExposureF",
multiple=True,
Expand Down Expand Up @@ -317,7 +317,7 @@ class UpdateVisitSummaryConnections(
)
background_originals = cT.Input(
doc="Per-detector original background that has already been subtracted from 'input_exposures'.",
name="calexpBackground",
name="initial_pvi_background",
dimensions=("instrument", "visit", "detector"),
storageClass="Background",
multiple=True,
Expand Down
Loading