DM-42087: Add more streak parameters to output #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrawls
reviewed
Sep 12, 2024
|
I took a slightly different approach, since I also added some documentation that was missing in the original commit. |
cmsaunders
force-pushed
the
tickets/DM-42087
branch
from
4d17821
to
64bc607
Compare
mrawls
reviewed
Sep 12, 2024
| @@ -221,6 +221,8 @@ def setDefaults(self): | |||
| "STREAK", "INJECTED", "INJECTED_TEMPLATE"] | |||
| self.skySources.avoidMask = ["DETECTED", "DETECTED_NEGATIVE", "BAD", "NO_DATA", "EDGE"] | |||
|
|
|||
| self.maskStreaks.onlyMaskDetected = False | |||
There was a problem hiding this comment.
This is a great place to set it, thank you - suggest one final inline comment e.g. # Set the streak mask along the entire fit line, not only where the detected mask is set
mrawls
approved these changes
Sep 12, 2024
cmsaunders
force-pushed
the
tickets/DM-42087
branch
from
64bc607
to
1afa11b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.