Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-41605: Command-line aggregator for pipetask report #437

Merged
merged 4 commits into from
Oct 16, 2024
Merged

Conversation

eigerx
Copy link
Contributor

@eigerx eigerx commented Aug 16, 2024

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@eigerx eigerx force-pushed the tickets/DM-41605 branch 2 times, most recently from 392b330 to 96c40bd Compare August 17, 2024 01:10
@eigerx eigerx force-pushed the tickets/DM-41605 branch 3 times, most recently from aadfd5f to e3a5cc4 Compare October 14, 2024 23:06
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 81.36364% with 41 lines in your changes missing coverage. Please review.

Project coverage is 83.21%. Comparing base (d975a85) to head (0639af2).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
tests/test_quantum_provenance_graph.py 78.60% 19 Missing and 21 partials ⚠️
python/lsst/pipe/base/quantum_provenance_graph.py 96.96% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #437      +/-   ##
==========================================
- Coverage   83.22%   83.21%   -0.01%     
==========================================
  Files          99       99              
  Lines       11861    12078     +217     
  Branches     1485     1524      +39     
==========================================
+ Hits         9871    10051     +180     
- Misses       1604     1621      +17     
- Partials      386      406      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eigerx eigerx force-pushed the tickets/DM-41605 branch 2 times, most recently from 02a2a82 to 08bf168 Compare October 15, 2024 19:21
@eigerx
Copy link
Contributor Author

eigerx commented Oct 15, 2024

The mypy error I'm getting here doesn't seem to be about my additions to the codebase. Can someone point me to what to do about issues with
python/lsst/pipe/base/tests/mocks/_storage_class.py:638: error: Argument 1 to "is_mock_name" has incompatible type "str | Any | None"; expected "str" [arg-type] python/lsst/pipe/base/tests/mocks/_storage_class.py:656: error: Argument 1 to "is_mock_name" has incompatible type "str | Any | None"; expected "str" [arg-type] Found 2 errors in 1 file (checked 79 source files)
?

@eigerx eigerx marked this pull request as ready for review October 16, 2024 21:12
Copy link

@villarrealas villarrealas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but consider a more descriptive variable like other_summary or the like.

@@ -485,6 +485,24 @@ def add_quantum_info(self, info: QuantumInfo, butler: Butler, do_store_logs: boo
case unrecognized_state:
raise AssertionError(f"Unrecognized quantum status {unrecognized_state!r}")

def add_data_id_group(self, other: TaskSummary) -> None:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use a more descriptive variable than other here?

@eigerx eigerx merged commit a403324 into main Oct 16, 2024
12 of 13 checks passed
@eigerx eigerx deleted the tickets/DM-41605 branch October 16, 2024 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants