SP-1601: clean up rubin-sim developer guide issues #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhiannonlynne
force-pushed
the
tickets/SP-1601
branch
3 times, most recently
from
044303d
to
4b5d393
Compare
rhiannonlynne
force-pushed
the
tickets/SP-1601
branch
from
450339c
to
384c674
Compare
yoachim
approved these changes
Oct 10, 2024
| sv2 = starlink_tles_v2() | ||
| ow = oneweb_tles() | ||
| _ = starlink_tles_v2() | ||
| _ = oneweb_tles() |
There was a problem hiding this comment.
Rather than set the other tles to _, I would just loop the test over [sv1, sv2, ow]. Or if that's slow, check that those functions return something reasonable with something like assert sv2 is not None.
There was a problem hiding this comment.
Good suggestions, will update.
|
I was also sad to remove the comcam slicer given that it would be useful now! It was just not in a state that was usable. I think updating the camera footprint generation code and making a comcam camera map would be good. |
rhiannonlynne
force-pushed
the
tickets/SP-1601
branch
from
7d872c3
to
ca30443
Compare
rhiannonlynne
force-pushed
the
tickets/SP-1601
branch
from
ca30443
to
76d8554
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Humna and Lynne are working on improving rubin-sim adherence to developer code guidelines, also this lets us look at workflow.