Avoid get on PackageMetadata in FastAPI template #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current mypy plus typeshed plus the Python 3.10 core library has a bug causing mypy to not think get is a valid method on the return value of importlib.metadata.metadata because it returns a Protocol that doesn't implement get. I've filed a issue in case this is not intended (python/typeshed#7767), but we know that any package created by this template will always have Summary and Version metadata, so we can use them unconditionally. Previously, this may not have worked in situations where the package was being used uninstalled, but since we now do everything including local development servers from inside tox, and make init also installs the package for running pytest directly, this should no longer be an issue. setuptools_scm should always generate a version, even if it's an unuseful one.
jonathansick
approved these changes
May 2, 2022
|
That's interesting. Thanks for filing the upstream ticket; but I agree that this is fine as a long-term solution too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current mypy plus typeshed plus the Python 3.10 core library
has a bug causing mypy to not think get is a valid method on the
return value of importlib.metadata.metadata because it returns a
Protocol that doesn't implement get. I've filed a issue in case
this is not intended (python/typeshed#7767),
but we know that any package created by this template will always
have Summary and Version metadata, so we can use them
unconditionally.
Previously, this may not have worked in situations where the
package was being used uninstalled, but since we now do everything
including local development servers from inside tox, and make init
also installs the package for running pytest directly, this should
no longer be an issue. setuptools_scm should always generate a
version, even if it's an unuseful one.