-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to v2 #14
Upgrade to v2 #14
Conversation
@@ -41,7 +41,7 @@ | |||
"repository": "https://github.com/lucasbento/graphql-pokemon", | |||
"scripts": { | |||
"eslint": "eslint src/*", | |||
"build": "rm -rf dist/* && babel src --out-dir dist --copy-files", | |||
"build-app": "rm -rf dist/* && babel src --out-dir dist --copy-files", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this change is not very clear
@@ -55,7 +55,7 @@ query { | |||
|
|||
```sh | |||
yarn | |||
yarn run build | |||
yarn run build-app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here as well
|
||
or | ||
|
||
vercel dev # npm i -g @now/cli |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vercel dev # npm i -g @now/cli | |
vercel dev # npm i -g vercel |
I'd love to see this merged! Was looking for a Pokemon GQL API today 😄 |
Which part of the changes that update to use the pokeAPI to work with v2? |
Why don't be merged yet? For me it's right ;) |
## Documentation / Examples - [x] Make sure the linting passes As mentioned in #25854 `with-urql` doesn't work. After investigation, I've found that Pokémon GraphQL server located at `https://graphql-pokemon.vercel.app` is down. After some research I came across its repository and this [pull request](lucasbento/graphql-pokemon#14). That pull request provides new URL `https://graphql-pokemon2.vercel.app` which seems to work. I don't know the status of this server, maybe @leerob can confirm this PR is ok.
Hey! Any update here? We're seen some issues from folks referencing this URL as it's now broken. If this project is deprecated, let me know and we can reassign the URL 👍 |
## Documentation / Examples - [x] Make sure the linting passes As mentioned in vercel#25854 `with-urql` doesn't work. After investigation, I've found that Pokémon GraphQL server located at `https://graphql-pokemon.vercel.app` is down. After some research I came across its repository and this [pull request](lucasbento/graphql-pokemon#14). That pull request provides new URL `https://graphql-pokemon2.vercel.app` which seems to work. I don't know the status of this server, maybe @leerob can confirm this PR is ok.
@leerob: merged, thank you so much for doing this and I'm very very sorry for not looking into it sooner. |
## Documentation / Examples - [x] Make sure the linting passes As mentioned in vercel#25854 `with-urql` doesn't work. After investigation, I've found that Pokémon GraphQL server located at `https://graphql-pokemon.vercel.app` is down. After some research I came across its repository and this [pull request](lucasbento/graphql-pokemon#14). That pull request provides new URL `https://graphql-pokemon2.vercel.app` which seems to work. I don't know the status of this server, maybe @leerob can confirm this PR is ok.
The old API was down and it was moved to this new endpoint lucasbento/graphql-pokemon#14 Also updates build_runner version to avoid incompatible version with artemis
The old API was down and it was moved to this new endpoint lucasbento/graphql-pokemon#14 Also updates build_runner version to avoid incompatible version with artemis
The old API was down and it was moved to this new endpoint lucasbento/graphql-pokemon#14 Also updates build_runner version to avoid incompatible version with artemis
The old API was down and it was moved to this new endpoint lucasbento/graphql-pokemon#14 Also updates build_runner version to avoid incompatible version with artemis
Addresses #13
Deployed example - https://graphql-pokemon2.vercel.app
Run locally with
vercel dev
to test.