New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow SDK versions to be overridden #74

Merged

lucasferreira merged 1 commit into lucasferreira:master from jeaye:configure-versions

Jul 23, 2018

Contributor

jeaye commented Jul 20, 2018 •

edited

Loading

This is a common pattern now, recommended by Google, in the following documentation: https://developer.android.com/studio/build/gradle-tips#configure-project-wide-properties

Many other libraries are taking the same approach, as shown in the following:


          Allow SDK versions to be overridden

cb5532b

This is a common pattern now, recommended by Google, in the following
documentation: https://developer.android.com/studio/build/gradle-tips#configure-project-wide-properties

Many other libraries are taking the same approach, as shown in the
following:

* react-native-maps/react-native-maps#2047
* https://github.com/transistorsoft/react-native-background-geolocation/blob/master/android/build.gradle#L3
*
https://github.com/rebeccahughes/react-native-device-info/blob/master/android/build.gradle#L3

Owner

lucasferreira commented Jul 23, 2018

Hi @jeaye thanks for this man ;)

lucasferreira merged commit 1477df4 into lucasferreira:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet