Skip to content

Commit

Permalink
fix(icons): combined layers and layers-3 icon (#2596)
Browse files Browse the repository at this point in the history
* Updated icons/layers.svg

* Updated icons/layers.json

* chore: removed layers-3 icon

* Update tools/build-icons/utils/deprecationReasonTemplate.mjs

---------

Co-authored-by: Eric Fennis <eric.fennis@gmail.com>
  • Loading branch information
jguddas and ericfennis authored Dec 3, 2024
1 parent 212b488 commit ee575f6
Show file tree
Hide file tree
Showing 6 changed files with 14 additions and 41 deletions.
2 changes: 1 addition & 1 deletion icon.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@
},
"aliasDeprecationReasons": {
"type": "string",
"enum": ["alias.typo", "alias.name"]
"enum": ["alias.typo", "alias.name", "alias.duplicate"]
},
"versionNumber": {
"type": "string",
Expand Down
21 changes: 0 additions & 21 deletions icons/layers-3.json

This file was deleted.

15 changes: 0 additions & 15 deletions icons/layers-3.svg

This file was deleted.

9 changes: 8 additions & 1 deletion icons/layers.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@
"$schema": "../icon.schema.json",
"contributors": [
"colebemis",
"danielbayley"
"danielbayley",
"jguddas"
],
"tags": [
"stack",
Expand All @@ -16,5 +17,11 @@
"categories": [
"design",
"layout"
],
"aliases": [
{
"name": "layers-3",
"deprecationReason": "alias.duplicate"
}
]
}
6 changes: 3 additions & 3 deletions icons/layers.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 2 additions & 0 deletions tools/build-icons/utils/deprecationReasonTemplate.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ export default function deprecationReasonTemplate(
switch (deprecationReason) {
case 'alias.typo':
return `Renamed because of typo, use {@link ${componentName}} instead.${removalNotice}`;
case 'alias.duplicate':
return `The icon was combined with another icon that shares the same use case, use {@link ${componentName}} instead.${removalNotice}`;
case 'alias.naming':
return `The name of this icon was changed because it didn't meet our guidelines anymore, use {@link ${componentName}} instead.${removalNotice}`;
case 'icon.brand':
Expand Down

0 comments on commit ee575f6

Please sign in to comment.