Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement deprecated block comment #1765

Merged
merged 14 commits into from
Jan 7, 2024
Merged

Conversation

ericfennis
Copy link
Member

@ericfennis ericfennis commented Dec 28, 2023

Contributes to #1687

What is the purpose of this pull request?

  • Implement deprecation field in meta json and build flow to show it in block comments

Description

Implement deprecated block comment to show deprecated icons in IDEs.

Lucide React example:
image

Implemented in Packages :

  • lucide
  • lucide-react
  • lucide-svelte
  • lucide-angular
  • lucide-react-native
  • lucide-vue
  • lucide-solid
  • lucide-vue-next
  • lucide-preact
  • lucide-static

@ericfennis ericfennis marked this pull request as draft December 28, 2023 14:02
@github-actions github-actions bot added the 🫧 metadata Improved metadata label Dec 28, 2023
@ericfennis ericfennis changed the title Implement deprecate comment Implement deprecated block comment Dec 28, 2023
@github-actions github-actions bot added 📦 dependencies Pull requests that update a dependency file 🪨 static package About the static package labels Jan 5, 2024
@ericfennis ericfennis marked this pull request as ready for review January 5, 2024 11:13
@ericfennis ericfennis merged commit ef89510 into main Jan 7, 2024
14 checks passed
@ericfennis ericfennis deleted the implement-deprecate-comment branch January 7, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 dependencies Pull requests that update a dependency file 🫧 metadata Improved metadata 🪨 static package About the static package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants