Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icons): add earbuds #2224

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

MONOTYPEEE
Copy link

@MONOTYPEEE MONOTYPEEE commented Jun 17, 2024

What is the purpose of this pull request?

  • New Icon
  • Bug fix
  • New Feature
  • Documentation update
  • Other:

Description

two types of Wireless Earbud icon that common shapes in market

Icon use case

  • signify earphone/wireless earbuds
  • represent audio control on UI

Alternative icon designs

Icon Design Checklist

Concept

  • I have provided valid use cases for each icon.
  • I have not added any a brand or logo icon.
  • I have not used any hate symbols.
  • I have not included any religious or political imagery.

Author, credits & license

  • The icons are solely my own creation.
  • The icons were originally created in # by @
  • I've based them on the following Lucide icons:
  • I've based them on the following design:

Naming

  • I've read and followed the naming conventions
  • I've named icons by what they are rather than their use case.
  • I've provided meta JSON files in icons/[iconName].json.

Design

  • I've read and followed the icon design guidelines
  • I've made sure that the icons look sharp on low DPI displays.
  • I've made sure that the icons look consistent with the icon set in size, optical volume and density.
  • I've made sure that the icons are visually centered.
  • I've correctly optimized all icons to three points of precision.

Before Submitting

@github-actions github-actions bot added 🎨 icon About new icons 🫧 metadata Improved metadata labels Jun 17, 2024
Copy link

github-actions bot commented Jun 17, 2024

Added or changed icons

icons/earbud.svg

Preview cohesion icons/message-square-quote.svg
icons/earbud.svg
icons/square-code.svg
Preview stroke widths icons/earbud.svg
icons/earbud.svg
icons/earbud.svg
DPI Preview (24px) icons/earbud.svg
Icon X-rays icons/earbud.svg
Icon Diffs icons/earbud.svg
Icons as code

Works for: lucide-react, lucide-react-native, lucide-preact, lucide-vue-next

const EarbudIcon = createLucideIcon('Earbud', [
  ["path",{"d":"M11 6q0-3 3-3a6 6 0 0 1 6 6v10a2 2 0 0 1-4 0v-7c-2 2-5 0-5-1.667"}],
  ["path",{"d":"M4 9c0 3 3 4 5 4a2 2 0 0 0 2-2V5a2 2 0 0 0-2-2C7 3 4 4 4 7z"}]
])

@karsa-mistmere
Copy link
Member

Hi @MONOTYPEEE,

Thanks for submitting these icons, all in all they're pretty well thought out, however, can you make sure that you follow our icon design guidelines, naming conventions and coding conventions to a tee?

I've found the following issues:

  1. earbud-2 is a disallowed naming scheme: "icon names for alternate icons should represent what makes the alternate unique instead of being numbered."

  2. There are several linting issues, GitHub Actions has highlighted these for you, I'd also suggest running prettier -w icons, this will take care of almost all these issues.

  3. earbud-2 has pretty wonky paths, it could to with much better curvature, especially the bottom left path:

image
  1. earbud-2 also has a minor guideline violation of our 2px gap guideline in this part (see the overlapping outlines):
image
  1. Both icons have a bit too low visual weight.

@MONOTYPEEE MONOTYPEEE changed the title feat(icons): add earbuds feat(icons): add earbuds (#2224) Jun 18, 2024
@MONOTYPEEE MONOTYPEEE changed the title feat(icons): add earbuds (#2224) feat(icons): add earbuds Jun 18, 2024
@MONOTYPEEE
Copy link
Author

MONOTYPEEE commented Jun 18, 2024

earbud-2 is a disallowed naming scheme

maybe earbud-stem/earbud works? (I thought those shapes doesn't have normal names for everyone)

There are several linting issues

my vsc is quite broken. I'll fix when commit new icon

@MONOTYPEEE
Copy link
Author

MONOTYPEEE commented Jun 18, 2024

  1. earbud-2 has pretty wonky paths
image



  1. earbud-2 also has a minor guideline violation
image

cound move vent 1px down or try the curved one.

@karsa-mistmere
Copy link
Member

  1. earbud-2 has pretty wonky paths
image > 4. earbud-2 also has a minor guideline violation image cound move vent 1px down or try the curved one.

These already look much better. Can you post 100% views of these? (export from Figma at 1x)

@jguddas
Copy link
Member

jguddas commented Jun 18, 2024

Can you post 100% views of these? (export from Figma at 1x)

Preferably even just split the PR up so you have one PR per icon.

@MONOTYPEEE
Copy link
Author

MONOTYPEEE commented Jun 19, 2024

image
bolder stem / moved below / curved

@karsa-mistmere
Copy link
Member

image bolder stem / moved below / curved

This is a 200% or 2px view, can you post one where you set the export size to 1x?
image

@MONOTYPEEE
Copy link
Author

Group 1

Copy link

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons 🫧 metadata Improved metadata Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants