-
-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(icons): fix volume
icons, add volume-off
#2378
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added or changed iconsIcons as codeWorks for: const VolumeOffIcon = createLucideIcon('VolumeOff', [
["path",{"d":"M16 9a5 5 0 0 1 .95 2.293"}],
["path",{"d":"M19.364 5.636a9 9 0 0 1 1.889 9.96"}],
["path",{"d":"m2 2 20 20"}],
["path",{"d":"m7 7-.587.587A1.4 1.4 0 0 1 5.416 8H3a1 1 0 0 0-1 1v6a1 1 0 0 0 1 1h2.416a1.4 1.4 0 0 1 .997.413l3.383 3.384A.705.705 0 0 0 11 19.298V11"}],
["path",{"d":"M9.828 4.172A.686.686 0 0 1 11 4.657v.686"}]
])
const FileVolumeIcon = createLucideIcon('FileVolume', [
["path",{"d":"M11 11a5 5 0 0 1 0 6"}],
["path",{"d":"M14 2v4a2 2 0 0 0 2 2h4"}],
["path",{"d":"M4 6.765V4a2 2 0 0 1 2-2h9l5 5v13a2 2 0 0 1-2 2H6a2 2 0 0 1-.93-.23"}],
["path",{"d":"M7 10.51a.5.5 0 0 0-.826-.38l-1.893 1.628A1 1 0 0 1 3.63 12H2.5a.5.5 0 0 0-.5.5v3a.5.5 0 0 0 .5.5h1.129a1 1 0 0 1 .652.242l1.893 1.63a.5.5 0 0 0 .826-.38z"}]
])
const Volume1Icon = createLucideIcon('Volume1', [
["path",{"d":"M11 4.702a.705.705 0 0 0-1.203-.498L6.413 7.587A1.4 1.4 0 0 1 5.416 8H3a1 1 0 0 0-1 1v6a1 1 0 0 0 1 1h2.416a1.4 1.4 0 0 1 .997.413l3.383 3.384A.705.705 0 0 0 11 19.298z"}],
["path",{"d":"M16 9a5 5 0 0 1 0 6"}]
])
const Volume2Icon = createLucideIcon('Volume2', [
["path",{"d":"M11 4.702a.705.705 0 0 0-1.203-.498L6.413 7.587A1.4 1.4 0 0 1 5.416 8H3a1 1 0 0 0-1 1v6a1 1 0 0 0 1 1h2.416a1.4 1.4 0 0 1 .997.413l3.383 3.384A.705.705 0 0 0 11 19.298z"}],
["path",{"d":"M16 9a5 5 0 0 1 0 6"}],
["path",{"d":"M19.364 18.364a9 9 0 0 0 0-12.728"}]
])
const VolumeXIcon = createLucideIcon('VolumeX', [
["path",{"d":"M11 4.702a.705.705 0 0 0-1.203-.498L6.413 7.587A1.4 1.4 0 0 1 5.416 8H3a1 1 0 0 0-1 1v6a1 1 0 0 0 1 1h2.416a1.4 1.4 0 0 1 .997.413l3.383 3.384A.705.705 0 0 0 11 19.298z"}],
["line",{"x1":"22","x2":"16","y1":"9","y2":"15"}],
["line",{"x1":"16","x2":"22","y1":"9","y2":"15"}]
])
const VolumeIcon = createLucideIcon('Volume', [
["path",{"d":"M11 4.702a.705.705 0 0 0-1.203-.498L6.413 7.587A1.4 1.4 0 0 1 5.416 8H3a1 1 0 0 0-1 1v6a1 1 0 0 0 1 1h2.416a1.4 1.4 0 0 1 .997.413l3.383 3.384A.705.705 0 0 0 11 19.298z"}]
]) |
jguddas
approved these changes
Aug 16, 2024
ericfennis
approved these changes
Aug 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicee
3 tasks
sanchitrk
added a commit
to zyghq/zyg
that referenced
this pull request
Sep 18, 2024
![snyk-top-banner](https://github.com/andygongea/OWASP-Benchmark/assets/818805/c518c423-16fe-447e-b67f-ad5a49b5d123) <h3>Snyk has created this PR to upgrade lucide-react from 0.379.0 to 0.435.0.</h3> :information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project. <hr/> - The recommended version is **50 versions** ahead of your current version. - The recommended version was released on **21 days ago**. <details> <summary><b>Release notes</b></summary> <br/> <details> <summary>Package name: <b>lucide-react</b></summary> <ul> <li> <b>0.435.0</b> - <a href="https://github.com/lucide-icons/lucide/releases/tag/0.435.0">2024-08-23</a></br><h2>Modified Icons 🔨</h2> <ul> <li><code>milestone</code> (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2389170587" data-permission-text="Title is private" data-url="lucide-icons/lucide#2281" data-hovercard-type="pull_request" data-hovercard-url="/lucide-icons/lucide/pull/2281/hovercard" href="https://github.com/lucide-icons/lucide/pull/2281">#2281</a>) by <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/jguddas/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/jguddas">@ jguddas</a></li> <li><code>signpost</code> (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2389170587" data-permission-text="Title is private" data-url="lucide-icons/lucide#2281" data-hovercard-type="pull_request" data-hovercard-url="/lucide-icons/lucide/pull/2281/hovercard" href="https://github.com/lucide-icons/lucide/pull/2281">#2281</a>) by <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/jguddas/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/jguddas">@ jguddas</a></li> </ul> </li> <li> <b>0.434.0</b> - <a href="https://github.com/lucide-icons/lucide/releases/tag/0.434.0">2024-08-23</a></br><h2>New icons 🎨</h2> <ul> <li><code>volume-off</code> (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2470475482" data-permission-text="Title is private" data-url="lucide-icons/lucide#2378" data-hovercard-type="pull_request" data-hovercard-url="/lucide-icons/lucide/pull/2378/hovercard" href="https://github.com/lucide-icons/lucide/pull/2378">#2378</a>) by <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/karsa-mistmere/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/karsa-mistmere">@ karsa-mistmere</a></li> </ul> <h2>Modified Icons 🔨</h2> <ul> <li><code>file-volume</code> (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2470475482" data-permission-text="Title is private" data-url="lucide-icons/lucide#2378" data-hovercard-type="pull_request" data-hovercard-url="/lucide-icons/lucide/pull/2378/hovercard" href="https://github.com/lucide-icons/lucide/pull/2378">#2378</a>) by <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/karsa-mistmere/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/karsa-mistmere">@ karsa-mistmere</a></li> <li><code>volume-1</code> (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2470475482" data-permission-text="Title is private" data-url="lucide-icons/lucide#2378" data-hovercard-type="pull_request" data-hovercard-url="/lucide-icons/lucide/pull/2378/hovercard" href="https://github.com/lucide-icons/lucide/pull/2378">#2378</a>) by <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/karsa-mistmere/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/karsa-mistmere">@ karsa-mistmere</a></li> <li><code>volume-2</code> (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2470475482" data-permission-text="Title is private" data-url="lucide-icons/lucide#2378" data-hovercard-type="pull_request" data-hovercard-url="/lucide-icons/lucide/pull/2378/hovercard" href="https://github.com/lucide-icons/lucide/pull/2378">#2378</a>) by <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/karsa-mistmere/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/karsa-mistmere">@ karsa-mistmere</a></li> <li><code>volume-x</code> (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2470475482" data-permission-text="Title is private" data-url="lucide-icons/lucide#2378" data-hovercard-type="pull_request" data-hovercard-url="/lucide-icons/lucide/pull/2378/hovercard" href="https://github.com/lucide-icons/lucide/pull/2378">#2378</a>) by <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/karsa-mistmere/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/karsa-mistmere">@ karsa-mistmere</a></li> <li><code>volume</code> (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2470475482" data-permission-text="Title is private" data-url="lucide-icons/lucide#2378" data-hovercard-type="pull_request" data-hovercard-url="/lucide-icons/lucide/pull/2378/hovercard" href="https://github.com/lucide-icons/lucide/pull/2378">#2378</a>) by <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/karsa-mistmere/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/karsa-mistmere">@ karsa-mistmere</a></li> </ul> </li> <li> <b>0.433.0</b> - <a href="https://github.com/lucide-icons/lucide/releases/tag/0.433.0">2024-08-23</a></br><h2>New icons 🎨</h2> <ul> <li><code>trending-up-down</code> (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2467900248" data-permission-text="Title is private" data-url="lucide-icons/lucide#2372" data-hovercard-type="pull_request" data-hovercard-url="/lucide-icons/lucide/pull/2372/hovercard" href="https://github.com/lucide-icons/lucide/pull/2372">#2372</a>) by <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/Alportan/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/Alportan">@ Alportan</a></li> </ul> <h2>Fixes Lucide Solid</h2> <ul> <li>Fixed compilation issues when starting up Vite Dev server by <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/ericfennis/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/ericfennis">@ ericfennis</a> in <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2470215746" data-permission-text="Title is private" data-url="lucide-icons/lucide#2375" data-hovercard-type="pull_request" data-hovercard-url="/lucide-icons/lucide/pull/2375/hovercard" href="https://github.com/lucide-icons/lucide/pull/2375">#2375</a></li> </ul> </li> <li> <b>0.432.0</b> - <a href="https://github.com/lucide-icons/lucide/releases/tag/0.432.0">2024-08-23</a></br><h2>New icons 🎨</h2> <ul> <li><code>chart-gantt</code> (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2472141724" data-permission-text="Title is private" data-url="lucide-icons/lucide#2392" data-hovercard-type="pull_request" data-hovercard-url="/lucide-icons/lucide/pull/2392/hovercard" href="https://github.com/lucide-icons/lucide/pull/2392">#2392</a>) by <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/jguddas/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/jguddas">@ jguddas</a></li> </ul> <h2>Modified Icons 🔨</h2> <ul> <li><code>contact-round</code> (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2472125869" data-permission-text="Title is private" data-url="lucide-icons/lucide#2391" data-hovercard-type="pull_request" data-hovercard-url="/lucide-icons/lucide/pull/2391/hovercard" href="https://github.com/lucide-icons/lucide/pull/2391">#2391</a>) by <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/jguddas/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/jguddas">@ jguddas</a></li> <li><code>contact</code> (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2472125869" data-permission-text="Title is private" data-url="lucide-icons/lucide#2391" data-hovercard-type="pull_request" data-hovercard-url="/lucide-icons/lucide/pull/2391/hovercard" href="https://github.com/lucide-icons/lucide/pull/2391">#2391</a>) by <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/jguddas/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/jguddas">@ jguddas</a></li> </ul> </li> <li> <b>0.429.0</b> - 2024-08-21 </li> <li> <b>0.428.0</b> - 2024-08-16 </li> <li> <b>0.427.0</b> - 2024-08-09 </li> <li> <b>0.426.0</b> - 2024-08-08 </li> <li> <b>0.425.0</b> - 2024-08-08 </li> <li> <b>0.424.0</b> - 2024-08-02 </li> <li> <b>0.423.0</b> - 2024-08-02 </li> <li> <b>0.422.0</b> - 2024-08-02 </li> <li> <b>0.421.0</b> - 2024-08-02 </li> <li> <b>0.420.0</b> - 2024-08-02 </li> <li> <b>0.419.0</b> - 2024-08-01 </li> <li> <b>0.418.0</b> - 2024-07-31 </li> <li> <b>0.417.0</b> - 2024-07-28 </li> <li> <b>0.416.0</b> - 2024-07-25 </li> <li> <b>0.415.0</b> - 2024-07-25 </li> <li> <b>0.414.0</b> - 2024-07-22 </li> <li> <b>0.413.0</b> - 2024-07-22 </li> <li> <b>0.412.0</b> - 2024-07-20 </li> <li> <b>0.411.0</b> - 2024-07-19 </li> <li> <b>0.410.0</b> - 2024-07-19 </li> <li> <b>0.409.0</b> - 2024-07-19 </li> <li> <b>0.408.0</b> - 2024-07-12 </li> <li> <b>0.407.0</b> - 2024-07-09 </li> <li> <b>0.406.0</b> - 2024-07-09 </li> <li> <b>0.405.0</b> - 2024-07-09 </li> <li> <b>0.404.0</b> - 2024-07-09 </li> <li> <b>0.403.0</b> - 2024-07-08 </li> <li> <b>0.402.0</b> - 2024-07-08 </li> <li> <b>0.401.0</b> - 2024-07-07 </li> <li> <b>0.400.0</b> - 2024-07-01 </li> <li> <b>0.399.0</b> - 2024-06-28 </li> <li> <b>0.398.0</b> - 2024-06-28 </li> <li> <b>0.397.0</b> - 2024-06-26 </li> <li> <b>0.396.0</b> - 2024-06-21 </li> <li> <b>0.395.0</b> - 2024-06-14 </li> <li> <b>0.394.0</b> - 2024-06-10 </li> <li> <b>0.391.0</b> - 2024-06-10 </li> <li> <b>0.390.0</b> - 2024-06-06 </li> <li> <b>0.387.0</b> - 2024-06-06 </li> <li> <b>0.386.0</b> - 2024-06-06 </li> <li> <b>0.385.0</b> - 2024-06-06 </li> <li> <b>0.384.0</b> - 2024-06-06 </li> <li> <b>0.383.0</b> - 2024-06-02 </li> <li> <b>0.382.0</b> - 2024-06-02 </li> <li> <b>0.381.0</b> - 2024-05-30 </li> <li> <b>0.380.0</b> - 2024-05-30 </li> <li> <b>0.379.0</b> - 2024-05-21 </li> </ul> from <a href="https://github.com/lucide-icons/lucide/releases">lucide-react GitHub release notes</a> </details> </details> --- > [!IMPORTANT] > > - Check the changes in this PR to ensure they won't cause issues with your project. > - This PR was automatically created by Snyk using the credentials of a real user. --- **Note:** _You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs._ **For more information:** <img src="https://api.segment.io/v1/pixel/track?data=eyJ3cml0ZUtleSI6InJyWmxZcEdHY2RyTHZsb0lYd0dUcVg4WkFRTnNCOUEwIiwiYW5vbnltb3VzSWQiOiI5YWMzODA0MS1hMGJmLTQ0ODgtYTk0NC04MDkxZjZlZDk0YTUiLCJldmVudCI6IlBSIHZpZXdlZCIsInByb3BlcnRpZXMiOnsicHJJZCI6IjlhYzM4MDQxLWEwYmYtNDQ4OC1hOTQ0LTgwOTFmNmVkOTRhNSJ9fQ==" width="0" height="0"/> > - 🧐 [View latest project report](https://app.snyk.io/org/sanchitrk/project/9a9f7a5d-de7e-4f88-93a2-a4ae7546f8c7?utm_source=github&utm_medium=referral&page=upgrade-pr) > - 📜 [Customise PR templates](https://docs.snyk.io/scan-using-snyk/pull-requests/snyk-fix-pull-or-merge-requests/customize-pr-templates) > - 🛠 [Adjust upgrade PR settings](https://app.snyk.io/org/sanchitrk/project/9a9f7a5d-de7e-4f88-93a2-a4ae7546f8c7/settings/integration?utm_source=github&utm_medium=referral&page=upgrade-pr) > - 🔕 [Ignore this dependency or unsubscribe from future upgrade PRs](https://app.snyk.io/org/sanchitrk/project/9a9f7a5d-de7e-4f88-93a2-a4ae7546f8c7/settings/integration?pkg=lucide-react&utm_source=github&utm_medium=referral&page=upgrade-pr#auto-dep-upgrades) [//]: # 'snyk:metadata:{"customTemplate":{"variablesUsed":[],"fieldsUsed":[]},"dependencies":[{"name":"lucide-react","from":"0.379.0","to":"0.435.0"}],"env":"prod","hasFixes":false,"isBreakingChange":false,"isMajorUpgrade":false,"issuesToFix":[],"prId":"9ac38041-a0bf-4488-a944-8091f6ed94a5","prPublicId":"9ac38041-a0bf-4488-a944-8091f6ed94a5","packageManager":"npm","priorityScoreList":[],"projectPublicId":"9a9f7a5d-de7e-4f88-93a2-a4ae7546f8c7","projectUrl":"https://app.snyk.io/org/sanchitrk/project/9a9f7a5d-de7e-4f88-93a2-a4ae7546f8c7?utm_source=github&utm_medium=referral&page=upgrade-pr","prType":"upgrade","templateFieldSources":{"branchName":"default","commitMessage":"default","description":"default","title":"default"},"templateVariants":[],"type":"auto","upgrade":[],"upgradeInfo":{"versionsDiff":50,"publishedDate":"2024-08-23T09:34:04.739Z"},"vulns":[]}'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Description
Our
volume
icons have pretty ugly corners (non-guideline-compliant, too sharp, too dense), this redesign brings the set much closer to what other icons in Lucide look like. Also added is avolume-off
icon.Icon use case
volume-off
: whilevolume-x
can stand for volume being turned down to the absolute lowest, effectively being muted,volume-off
is a much more straightforward mute/muted icon for various reasons:wifi-off
Icon Design Checklist
Concept
Author, credits & license
volume
Naming
icons/[iconName].json
.Design
Before Submitting