-
-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(icons): added bullhorn
icon
#2448
base: main
Are you sure you want to change the base?
Conversation
Rounded the corners and increased the gap inside the handle
Added or changed iconsIcons as codeWorks for: const MegaphoneOffIcon = createLucideIcon('MegaphoneOff', [
["path",{"d":"M10.657 5H11a13 13 0 0 0 8.4-2.8A1 1 0 0 1 21 3v12.343"}],
["path",{"d":"M13 13H5a2 2 0 0 1-2-2V7a2 2 0 0 1 2-2"}],
["path",{"d":"m2 2 20 20"}],
["path",{"d":"M6 13a12 12 0 0 0 2.4 7.2 2 2 0 1 0 3.2-2.4A8 8 0 0 1 10 13"}],
["path",{"d":"M8 8v5"}]
])
const MegaphoneIcon = createLucideIcon('Megaphone', [
["path",{"d":"M11 6a13 13 0 0 0 8.4-2.8A1 1 0 0 1 21 4v12a1 1 0 0 1-1.6.8A13 13 0 0 0 11 14H5a2 2 0 0 1-2-2V8a2 2 0 0 1 2-2z"}],
["path",{"d":"M6 14a12 12 0 0 0 2.4 7.2 2 2 0 0 0 3.2-2.4A8 8 0 0 1 10 14"}],
["path",{"d":"M8 6v8"}]
]) |
We do also have a To be honest, I'm not quite sure about having these both, since they're so similar, but let's wait for what @jguddas and @ericfennis have to say. |
I agree with @karsa-mistmere. |
Also calling @jakajancar, who originally submitted the request, @jamiemlaw is "only" the implementor here. :) |
@ericfennis @karsa-mistmere To me, the electric is more aggressive in nature than the acoustic. Acoustic: "Roll up! Roll up! Get your icons! Icons here!" I could imagine a scenario where a user has the current |
Maybe hard to do but if we were to give the icons a little tilt it might look more shouty. |
I'm not a fan, that would make them look far too cartoony. |
Maybe megaphone-electric is a better name. |
I would like it because I have never heard of an acoustic/cheerleading megaphone before, was completely unfamiliar with the shape, and the icon was unrecognizable to me. But maybe I'm just ignorant 😅 FWIW at least, a Google search for "megaphone icon" returns 23 electric ones (rounded and/or diaphragm in the center) and only 1 acoustic/cheerleading one (straight cone without a diaphragm in the center): |
In that case, I'd be happy to rename |
Based on existing megaphone emoji designs, every single one of which uses roughly the same shape and concept as we currently do, I'd vote to just update |
closes #2438
What is the purpose of this pull request?
Description
bullhorn
that depicts an electric megaphonemegaphone
icon and increased the gap inside the handle to better match Lucide's current guidelinesloudspeaker
as a keyword for users searching for that termThis PR is in response to #2438, requesting an electric megaphone. Lucide already has a megaphone icon, but it shows an acoustic megaphone. Those two different types of megaphone can have different connotations, acoustic being used for announcements but electric for crowd control. Therefore it seemed like a breaking change to change the style from one to the other.
Therefore, I have added the electric megaphone as a new icon,
bullhorn
, (name justification) but made sure to addmegaphone
as a tag, so it will show up in those searches.Icon Design Checklist
Concept
Author, credits & license
Naming
icons/[iconName].json
.Design
Before Submitting