Several improvement about supergroup and channel #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -41,12 +42,19 @@ def fix_message(message): | |||
|
|
|||
|
|
|||
| def fix_peer(peer): | |||
| # rename peer_type => type | |||
| if peer["peer_type"]: | |||
There was a problem hiding this comment.
To check for existence too, use
if "peer_type" in peer and peer["peer_type"]:That above only checks the value of that attribute.
It will fail, if there is no "peer_type" key.
|
Wow, looking good. |
| @@ -134,6 +134,7 @@ | |||
| # functions["channel_set_admin"] = ("channel_set_admin", <channel> <admin> <type> Sets channel admin. 0 - not admin, 1 - moderator, 2 - editor | |||
There was a problem hiding this comment.
Maybe you can have a look at this old line here, while your on it.
I wonder why channel_set_admin is not implemented.
|
I test it in Python 3.5.1 |
|
Thanks! Also don't miss my comment added above |
|
I am gonna Merge this. In case something fails we should just open a new issue. |
| @@ -85,6 +85,12 @@ def parse(self, value): | |||
| return super(User, self).parse(value) | |||
|
|
|||
|
|
|||
| class Channel(Peer): | |||
There was a problem hiding this comment.
This is a duplicate of line 100...?
Will fix this.
|
And it is in Version 0.4.6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Adds
Sender.channel_rename(...),a
Channelargument type,and fixes for the related dict entries (
fix_messageandfix_peer).Original Pull Request by @huiyiqun:
I have written a tg-based bot with your project.
In order to work with supergroup, I compiled the telegram-cli from the test branch and fix some problem of pytz. What's more, some missing features are added.
I'm glad if these code help.