-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create generic DB_CACHE
functions for db.Model
classes
#1011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michplunkett
commented
Aug 4, 2023
@@ -87,7 +87,7 @@ def __init__( | |||
("IVANA", "", "TINKLE"), | |||
("SEYMOUR", "", "BUTZ"), | |||
("HAYWOOD", "U", "CUDDLEME"), | |||
("BEA", "", "PROBLEM"), | |||
("BEA", "", "O'PROBLEM"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
michplunkett
requested review from
AetherUnbound,
abandoned-prototype and
null-space-0
August 4, 2023 22:47
abandoned-prototype
approved these changes
Aug 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have any background with this caching library, but to the extent I can judge it, it looks good to me
michplunkett
changed the title
Create cache file for key logic
Create generic Aug 7, 2023
DB_CACHE
functions for db.Model
classes
sea-kelp
pushed a commit
to OrcaCollective/OpenOversight
that referenced
this pull request
Sep 25, 2023
…ns#1011) lucyparsons#997 I created a cacheing file that allows us to remove values from the cache when its underlying dataset has changed for all versions of a `SQLAlchemy` `Model`. - [x] This branch is up-to-date with the `develop` branch. - [x] `pytest` passes on my local development environment. - [x] `pre-commit` passes on my local development environment.
sea-kelp
pushed a commit
to OrcaCollective/OpenOversight
that referenced
this pull request
Sep 25, 2023
…ns#1011) lucyparsons#997 I created a cacheing file that allows us to remove values from the cache when its underlying dataset has changed for all versions of a `SQLAlchemy` `Model`. - [x] This branch is up-to-date with the `develop` branch. - [x] `pytest` passes on my local development environment. - [x] `pre-commit` passes on my local development environment.
sea-kelp
pushed a commit
to OrcaCollective/OpenOversight
that referenced
this pull request
Oct 9, 2023
…ns#1011) lucyparsons#997 I created a cacheing file that allows us to remove values from the cache when its underlying dataset has changed for all versions of a `SQLAlchemy` `Model`. - [x] This branch is up-to-date with the `develop` branch. - [x] `pytest` passes on my local development environment. - [x] `pre-commit` passes on my local development environment.
AetherUnbound
pushed a commit
to OrcaCollective/OpenOversight
that referenced
this pull request
Nov 11, 2023
…ns#1011) lucyparsons#997 I created a cacheing file that allows us to remove values from the cache when its underlying dataset has changed for all versions of a `SQLAlchemy` `Model`. - [x] This branch is up-to-date with the `develop` branch. - [x] `pytest` passes on my local development environment. - [x] `pre-commit` passes on my local development environment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue
#997
Description of Changes
I created a cacheing file that allows us to remove values from the cache when its underlying dataset has changed for all versions of a
SQLAlchemy
Model
.Tests and linting
develop
branch.pytest
passes on my local development environment.pre-commit
passes on my local development environment.