Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Downgrade sigstore to <2 #246

Merged
merged 2 commits into from
Nov 3, 2023
Merged

Downgrade sigstore to <2 #246

merged 2 commits into from
Nov 3, 2023

Conversation

ludeeus
Copy link
Owner

@ludeeus ludeeus commented Nov 3, 2023

Proposed change

Sigstore >2 requires pydantic <2 >3, which will cause other problems.
Downgrading for now.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionalit)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:

Checklist

  • The code change is tested and works locally.
  • Local tests pass.
  • There is no commented out code in this PR.
  • The code has been formatted using Black (make lint)
  • Tests have been added to verify that the new code works.

@ludeeus ludeeus merged commit 54a27f2 into main Nov 3, 2023
7 checks passed
@ludeeus ludeeus deleted the downgrade-sigstore branch November 3, 2023 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ludeeus