Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle secondary rate limit in device activation #264

Merged
merged 1 commit into from
Dec 10, 2023

Conversation

ludeeus
Copy link
Owner

@ludeeus ludeeus commented Dec 10, 2023

Proposed change

For some reason GitHub is returning a HTML page instead of JSON error for this issue when doing device activation (all other APIs return JSON for this...)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionalit)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:

Checklist

  • The code change is tested and works locally.
  • Local tests pass.
  • There is no commented out code in this PR.
  • The code has been formatted using Black (make lint)
  • Tests have been added to verify that the new code works.

@ludeeus ludeeus merged commit b885481 into main Dec 10, 2023
8 checks passed
@ludeeus ludeeus deleted the secondary-rate-limit-device-auth branch December 10, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant