Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds attributes to the repository object #4

Merged
merged 17 commits into from
Aug 2, 2020
Merged

Adds attributes to the repository object #4

merged 17 commits into from
Aug 2, 2020

Conversation

timmo001
Copy link
Contributor

@timmo001 timmo001 commented Aug 1, 2020

Adds a few extra properties to AIOGitHubAPIRepository and adds two new classes, AIOGitHubAPIRepositoryClones and AIOGitHubAPIRepositoryViews

Relates to home-assistant/core#38458

@timmo001 timmo001 marked this pull request as draft August 1, 2020 16:06
@timmo001 timmo001 marked this pull request as ready for review August 1, 2020 16:13
Copy link
Owner

@ludeeus ludeeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor name changes.
It also needs 100% coverage

aiogithubapi/objects/repository/__init__.py Outdated Show resolved Hide resolved
aiogithubapi/objects/repository/__init__.py Outdated Show resolved Hide resolved
aiogithubapi/objects/repository/__init__.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 2, 2020

Codecov Report

Merging #4 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master        #4   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           25        25           
  Lines         2805      2824   +19     
=========================================
+ Hits          2805      2824   +19     
Impacted Files Coverage Δ
aiogithubapi/objects/repository/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 473e616...ad47010. Read the comment docs.

ludeeus added a commit that referenced this pull request Aug 2, 2020
@timmo001
Copy link
Contributor Author

timmo001 commented Aug 2, 2020

Think I broke codecov 😄

@timmo001 timmo001 requested a review from ludeeus August 2, 2020 13:04
@ludeeus ludeeus changed the title Integration changes Adds attributes to the repository object Aug 2, 2020
@ludeeus ludeeus merged commit 1fd1b84 into ludeeus:master Aug 2, 2020
@timmo001 timmo001 deleted the integration-changes branch August 2, 2020 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants