Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Support preprocessing datetime.date date features #3534

Merged
merged 3 commits into from
Aug 16, 2023

Conversation

jeffkinnison
Copy link
Contributor

Currently, date feature preprocessing supports datetime.datetime objects, ISO time strings, custom time strings, and int/float timestamps. datetime.date objects, however, are considered invalid and replaced with the fill value despite being valid date features. This update

  • adds support for datetime.date objects to DateFeatureMixin.date_to_list
  • adds a test for datetime.date support

@github-actions
Copy link

github-actions bot commented Aug 15, 2023

Unit Test Results

  6 files  ±0    6 suites  ±0   1h 6m 7s ⏱️ - 3m 18s
34 tests ±0  29 ✔️ ±0    5 💤 ±0  0 ±0 
88 runs  ±0  72 ✔️ ±0  16 💤 ±0  0 ±0 

Results for commit 63a1891. ± Comparison against base commit 090918d.

♻️ This comment has been updated with latest results.

@jeffkinnison jeffkinnison merged commit 1b0774f into master Aug 16, 2023
15 checks passed
@jeffkinnison jeffkinnison deleted the date-obj-handling branch August 16, 2023 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants