Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update comment for predict to update Ludwig docs #3535

Merged
merged 2 commits into from
Sep 18, 2023

Conversation

Infernaught
Copy link
Contributor

Updated a comment for generate() under LudwigModel in api.py so that it would automatically reflect in the Ludwig docs.

@github-actions
Copy link

github-actions bot commented Aug 15, 2023

Unit Test Results

  6 files  ±0    6 suites  ±0   1h 3m 54s ⏱️ + 2m 4s
34 tests ±0  27 ✔️  - 2    7 💤 +2  0 ±0 
88 runs  ±0  64 ✔️  - 8  24 💤 +8  0 ±0 

Results for commit 46f8d96. ± Comparison against base commit 5ba3494.

This pull request skips 2 tests.
tests.regression_tests.benchmark.test_model_performance ‑ test_performance[ames_housing.gbm.yaml]
tests.regression_tests.benchmark.test_model_performance ‑ test_performance[mercedes_benz_greener.gbm.yaml]

♻️ This comment has been updated with latest results.

Copy link
Contributor

@justinxzhao justinxzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Tim, could you also change the format of this docstring back to sphinx-ish style like the other functions in this file?

I had changed the docstring to Google style, but the code_doc_autogen binary doesn't parse Google style docstrings correctly.

@Infernaught Infernaught merged commit 0303aea into ludwig-ai:master Sep 18, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants