Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store steps_per_epoch in Trainer #3601

Merged
merged 1 commit into from
Sep 14, 2023
Merged

Store steps_per_epoch in Trainer #3601

merged 1 commit into from
Sep 14, 2023

Conversation

hungcs
Copy link
Contributor

@hungcs hungcs commented Sep 12, 2023

This allows training callbacks (i.e. def on_batch_end(self, trainer, progress_tracker, save_path: str, sync_step: bool = True):) to use trainer.steps_per_epoch to render step-level progress bars

@github-actions
Copy link

Unit Test Results

       6 files  ±       0         6 suites  ±0   1h 19m 17s ⏱️ - 1m 37s
2 806 tests +2 772  2 793 ✔️ +2 764  12 💤 +7  1 +1 
2 849 runs  +2 761  2 827 ✔️ +2 755  21 💤 +5  1 +1 

For more details on these failures, see this check.

Results for commit d1aad75. ± Comparison against base commit 6931fe4.

@hungcs hungcs merged commit 3cbeea2 into master Sep 14, 2023
12 of 15 checks passed
@hungcs hungcs deleted the m branch September 14, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants