Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FE setup #6

Merged
merged 17 commits into from
Aug 1, 2022
Merged

FE setup #6

merged 17 commits into from
Aug 1, 2022

Conversation

m4n1ok
Copy link
Contributor

@m4n1ok m4n1ok commented Jul 20, 2022 •
edited
Loading

Setup basic FE structure with Node LTS, Yarn 1 latest, Tailwind + A17 Tailwind plugins, A17 behaviors, A17 helpers, Linter and format

Tasks:

  • Define default Node / NPM
  • Setup Eslint and update Prettier config
  • Setup FE structure with Tailwind and A17 Tailwind plugins
  • Add lazyload helpers
  • Setup A17 behaviors + helpers
  • Add components helpers and head
  • Improve Vite configuration
  • Add IDE/Editors configuration documentation

@m4n1ok m4n1ok marked this pull request as draft July 20, 2022 16:46
@luislavena
Copy link
Owner

cc @13twelve and @mrdoinel

@mrdoinel
Copy link

thank you @m4n1ok for switching back to NPM (cf the poll)

luislavena
luislavena requested changes Jul 28, 2022
View reviewed changes
.prettierignore Show resolved Hide resolved
.styleci.yml Outdated Show resolved Hide resolved
@m4n1ok @luislavena
build(front): set default Node and NPM version
3a75207 
- Use lts node version and latest yarn version as minimum required engines
- Add version files for nvm and others node version manager
- Pin fe dependencies
m4n1ok added 10 commits July 28, 2022 15:33
@m4n1ok
build(eslint): setup eslint sh command
7569c71
@m4n1ok
refactor(prettier): harmonise configuration between prettier and edit…
cef0638 
…or config and rules for specific files types
@m4n1ok
refactor(gitignore): update gitignore file structure
73e7ba2
@m4n1ok
feat(eslint): update doc and add composer alias command to run eslint
35967cf
@m4n1ok
feat(frontend): add tailwind configuration with A17 tailwinds plugins
a75152d
@m4n1ok
feat(frontend): add frontend views structure
ba12b4c 
Configure frontend views structure with shared components / variables,  vite, tailwind-css, A17-lazyload
@m4n1ok
build(linter): add stylelint linter and blade/tailwind plugins for pr…
1b5ef53 
…ettier
@m4n1ok
feat(frontend): add and configure a17-behaviors and js-helpers
75c39d8
@m4n1ok
build(fe-dependencies): allow update of dependencies to patches versions
15aab25
@m4n1ok
refactor(prettierignore): ignore public folder
17acfe9
@m4n1ok m4n1ok marked this pull request as ready for review July 28, 2022 15:30
@m4n1ok m4n1ok requested a review from luislavena July 28, 2022 15:30
@m4n1ok m4n1ok changed the title [WIP] FE setup FE setup Jul 28, 2022
@m4n1ok
Copy link
Contributor Author

m4n1ok commented Jul 28, 2022

Hello @luislavena, @mrdoinel, @13twelve,

I'm done with the basic setup for the frontend part. It includes frontend linters configuration and libraries we are using for most of our projects.

Related to the current implementation of head-assets.blade.php, Laravel's Team is working on some improvements around Vite directive. I'm waiting for this PR to be merged before adding logic for preload / defer attributes...

Please don't hesitate to take a look and share your feedbacks.

luislavena
luislavena approved these changes Aug 1, 2022
View reviewed changes
Copy link
Owner

@luislavena luislavena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! Thanks for addressing all the comments! ❤️

@luislavena luislavena merged commit af0edd5 into luislavena:main Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luislavena luislavena luislavena approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@m4n1ok @luislavena @mrdoinel