Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HELM] use minio on teresa chart #314

Merged
merged 1 commit into from
Oct 30, 2017
Merged

[HELM] use minio on teresa chart #314

merged 1 commit into from
Oct 30, 2017

Conversation

yagonobre
Copy link
Contributor

@yagonobre yagonobre commented Aug 29, 2017 •
edited by arnaldopereira
Loading

This change is Reviewable

@yagonobre yagonobre changed the title use minio on teresa helm [HELM] use minio on teresa chart Aug 29, 2017
aguerra
aguerra previously approved these changes Aug 29, 2017
View reviewed changes
@codecov-io
Copy link

codecov-io commented Aug 29, 2017 •
edited
Loading

Codecov Report

Merging #314 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #314   +/-   ##
=======================================
  Coverage   44.51%   44.51%           
=======================================
  Files          51       51           
  Lines        3799     3799           
=======================================
  Hits         1691     1691           
  Misses       2005     2005           
  Partials      103      103

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d90887...73cde06. Read the comment docs.

drgarcia1986
drgarcia1986 reviewed Aug 29, 2017
View reviewed changes
helm/chart/teresa/values.yaml
@@ -30,3 +30,6 @@ build:
cpu: 500m
memory: 1024Mi
debug: false
useMinio: false
minio:
serviceType: ClusterIP
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not ELB? are you thinking about minikube?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess that the minio will only be used by teresa then I don't need an ELB. Makes sense?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about that. (Don't forget you need to create the bucket before use with Teresa)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now this create the bucket

drgarcia1986
drgarcia1986 previously approved these changes Sep 8, 2017
View reviewed changes
@yagonobre
Copy link
Contributor Author

waiting helm/charts#2061

@drgarcia1986
Copy link
Contributor

What about this PR ?

@yagonobre
Copy link
Contributor Author

@drgarcia1986 needs rebase but LGTM

@yagonobre
Copy link
Contributor Author

@drgarcia1986 done

aguerra
aguerra previously approved these changes Oct 27, 2017
View reviewed changes
Copy link
Contributor

@aguerra aguerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yagonobre
Copy link
Contributor Author

@aguerra @drgarcia1986 rebased

aguerra
aguerra approved these changes Oct 27, 2017
View reviewed changes
Copy link
Contributor

@aguerra aguerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔁

@drgarcia1986 drgarcia1986 merged commit 0cfbb52 into master Oct 30, 2017
@drgarcia1986 drgarcia1986 deleted the yns-helm-minio branch October 30, 2017 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aguerra aguerra aguerra approved these changes

@drgarcia1986 drgarcia1986 drgarcia1986 left review comments

@lucianokadoya-luizalabs lucianokadoya-luizalabs lucianokadoya-luizalabs left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yagonobre @codecov-io @drgarcia1986 @aguerra @lucianokadoya-luizalabs