-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HELM] use minio on teresa chart #314
Conversation
Codecov Report
@@ Coverage Diff @@
## master #314 +/- ##
=======================================
Coverage 44.51% 44.51%
=======================================
Files 51 51
Lines 3799 3799
=======================================
Hits 1691 1691
Misses 2005 2005
Partials 103 103 Continue to review full report at Codecov.
|
@@ -30,3 +30,6 @@ build: | |||
cpu: 500m | |||
memory: 1024Mi | |||
debug: false | |||
useMinio: false | |||
minio: | |||
serviceType: ClusterIP |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not ELB? are you thinking about minikube?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess that the minio
will only be used by teresa
then I don't need an ELB. Makes sense?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about that. (Don't forget you need to create the bucket before use with Teresa)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now this create the bucket
e11c1e6
to
e4df115
Compare
e4df115
to
3eaa188
Compare
6e929d6
3eaa188
to
6e929d6
Compare
waiting helm/charts#2061 |
6e929d6
to
48852a6
Compare
What about this PR ? |
@drgarcia1986 needs rebase but LGTM |
080d0e9
to
268bc8f
Compare
@drgarcia1986 done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
268bc8f
to
73cde06
Compare
@aguerra @drgarcia1986 rebased |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔁
This change is