Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Urdu translations #867

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Add Urdu translations #867

merged 1 commit into from
Dec 4, 2023

Conversation

mmalik23
Copy link
Contributor

@mmalik23 mmalik23 commented Dec 3, 2023

Prerequisites

Put an x into the box(es) that apply:

  • This pull request fixes a bug.
  • This pull request adds a feature.
  • This pull request introduces breaking change.

Description

This commit adds urdu translations.

Urdu uses the Nastaliq script, read from right to left. This script's unique style will often require custom CSS. Because of these reasons, english text does not mix very well with urdu. I felt it important to translate as much as possible into Urdu for a better look and feel. For example, instead of 'Powered By' in English, using the Urdu word for 'Thanks' was chosen as a complete translation into Urdu might not work well due to differences in subject-verb order

Issues Resolved

List any existing issues this pull request resolves.

Checklist

Put an x into the box(es) that apply:

General

  • Describe what changes are being made
  • Explain why and how the changes were necessary and implemented respectively
  • Reference issue with #<ISSUE_NO> if applicable

Resources

  • If you have changed any SCSS code, run make release to regenerate all CSS files

Contributors

  • Add yourself to CONTRIBUTORS.md if you aren't on it already

Copy link
Owner

@luizdepra luizdepra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. :)

@luizdepra luizdepra merged commit 0fab52d into luizdepra:main Dec 4, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants