Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shell on Makefile command to make year appear on metadata #134

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

hasecilu
Copy link
Collaborator

@hasecilu hasecilu commented Apr 4, 2024

It seems the shell should used in order to date be used as command and not as a variable.
image

Copy link
Collaborator

@Finii Finii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some person seems to be rusty with Makefiles... 😬

image

@Finii
Copy link
Collaborator

Finii commented Apr 4, 2024

Ah, normally I would maybe expect something like

Copyright (c) 2014-2024, Lukas W

Suggest: Maybe add the start year.

10 years btw! 🎉

Almost.

Save the date

ommit 3e8fedad92525f20bc5cd1918b7ae7714638400b
Author: Lukas W <lukaswhl@gmail.com>
Date:   Thu Aug 7 20:52:26 2014 +0200

    Initial commit

@hasecilu
Copy link
Collaborator Author

hasecilu commented Apr 4, 2024

Ah, normally I would maybe expect something like

Good idea!

@hasecilu hasecilu force-pushed the fix/copyright_year branch from ef15e9d to e927ecb Compare April 4, 2024 18:21
@Finii
Copy link
Collaborator

Finii commented Apr 4, 2024

👍

@hasecilu hasecilu merged commit 5d52dfa into master Apr 4, 2024
@hasecilu hasecilu deleted the fix/copyright_year branch April 4, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants