Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FreeCAD logo #138

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Update FreeCAD logo #138

merged 1 commit into from
Jun 5, 2024

Conversation

hasecilu
Copy link
Collaborator

Recently there was a contest to choose new logo, results are published: https://forum.freecad.org/viewtopic.php?p=761131&hilit=logo#p761131

Copy link
Collaborator

@Finii Finii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! 👍

image

image

Edit: Add inkscape and fontforge view

@Finii
Copy link
Collaborator

Finii commented May 24, 2024

Suggestion: Remove stroke width

image

image

By setting to "no stroke paint"; fontforge takes the stroke width and modifies the path so that it includes the stoke width, so that the resulting in-font path will be different (because it follows the outline of the path including half of the stroke width).

Noticed that because in the images above (fontforge / inkscape) the points seemed slightly different.

image

I assume you created the svg by tracing the png, and then the path follows the border of the image - no additional stoke width is taken into account.

You can also just text-edit the svg and remove the stroke related tag (or however that is called).

image

@hasecilu hasecilu force-pushed the chore/update_freecad_logo branch from e65860a to 17d804f Compare May 24, 2024 15:07
@hasecilu
Copy link
Collaborator Author

Suggestion: Remove stroke width

Done. Also removed some redundant nodes.

The original file was also an SVG, I just made it monochrome

@Finii
Copy link
Collaborator

Finii commented May 29, 2024

I can not approve again. Approved is approved ;)
(Just in case you wait for me to say something)

Copy link
Collaborator

@Finii Finii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I can indeed approve again.
Maybe I got confused by the Gitlab workflow, where that is not possible. Iirc. There is a dedicated un-approve button.

@hasecilu
Copy link
Collaborator Author

hasecilu commented Jun 5, 2024

I can not approve again. Approved is approved ;)
(Just in case you wait for me to say something)

=) I was in the middle of reinstalling my OS and other stuff...
I'll merge this

@hasecilu hasecilu merged commit 5a496d1 into master Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants