Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Nobara Linux logo #143

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Add Nobara Linux logo #143

merged 1 commit into from
Oct 28, 2024

Conversation

hasecilu
Copy link
Collaborator

@hasecilu hasecilu commented Sep 5, 2024

@Finii
Copy link
Collaborator

Finii commented Sep 20, 2024

Technically there seem to be some problems.

For example note the 'path direction' indicators that I labelled with arrows. The direction changes in the middle?!
The problem is that there are 2 points where it looks like one point.
Multiple instances of these (some marked with circles).

A quick 'simplify' run in Inkscape fixes it (did not check if there are more problems).
Otoh the simplify run kind of breaks the sharp tip in the middle-bottom *sigh*

image
As in the PR

image
Direction indicators bigger

image
Simplify fixes most but raises new problems ;)

@Finii
Copy link
Collaborator

Finii commented Sep 20, 2024

fontforge does a simplification on import also, and most problems vanish then.

But here for example the tripple points make the resulting glyph needlessly complicated and they are not removed automatically.

image
Should probably be smooth instead

We use this fontforge function to import the svgs, note the default that simplify away the double points if they are close enough to each other:

image

image

@hasecilu
Copy link
Collaborator Author

I tried to simplify a little and got 26 nodes, what do you think?
image

image

@Finii
Copy link
Collaborator

Finii commented Sep 21, 2024

Great! Thank you!

If we look really really close (which I usually do NOT, so again, this does not need to be changed I guess), we can see some problem with these two points (see the problems from the images you shared above):

image

image

The handles of the upper point have less then 180 degrees on the upper side; that means that the outline will be convex there.
This can be changed if the node is set to 'smooth'.

One handle of the lower point is below the point. That means we have a very very thin outline there below the point; and that point is not on the extremes. This can be changed if that node is set to 'corner' or the handle length set to zero.

In the fontforge view you see how the "problems" converted:

image

The upper point is now represented by two nodes because fontforge wants to use joined control points and this is the only way to represent the convex structure (because we have now truetype outlines).

image

The lower point problem is repaired by the simplify fontforge runs automagically.

Copy link
Collaborator

@Finii Finii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I do not see interest in it (which was your question), but ready to merge from my point of view.

And a cute icon ;-)

@Finii
Copy link
Collaborator

Finii commented Oct 28, 2024

Ah this fixes #121.

@Finii Finii force-pushed the feat/nobara_linux branch from 55fa335 to 2391cb5 Compare October 28, 2024 07:44
@Finii Finii merged commit b494d79 into master Oct 28, 2024
@hasecilu hasecilu deleted the feat/nobara_linux branch October 28, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants