Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add River icon #144

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Add River icon #144

merged 1 commit into from
Oct 28, 2024

Conversation

hasecilu
Copy link
Collaborator

@hasecilu hasecilu commented Sep 5, 2024

A dynamic tiling Wayland compositor https://isaacfreund.com/software/river/
https://codeberg.org/river/river
Licence: GPL-3.0-or-later

@Finii
Copy link
Collaborator

Finii commented Sep 20, 2024

Nodes look excellent, all path closed (that turned up elsewhere again)

image

Only thing that makes me raise my eyebrows in question... There is quite some padding top/left/bottom/right. With most icons we keep that to zero or at least minimal. The only exceptions (icons with some padding, like River above)

  • Alpine
  • gtk
  • openscad

image
How other icons fill their 'cells'

Edit:

It might be that the padding is intentional. But I wanted to raise that question.

@hasecilu
Copy link
Collaborator Author

The padding was not planned, now it fills the space.

image

@hasecilu
Copy link
Collaborator Author

  • Alpine
  • gtk
  • openscad

The nodes/edges of these are already touching the canvas edge, unless we want to go bigger and cross the canvas boundary as in Kali Linux. Also dwm, XFCE look small.

@Finii
Copy link
Collaborator

Finii commented Sep 21, 2024

You are right, I do not know what I saw 🤔

Except for openscad

image

Some more like XFCE have a less pronounced border.

The "problem" is that we first scale the svg into the font 'cell' and then we remove the borders / bearing; this means that the advance width will be smaller, not that the icon gets bigger.

Anyhow :-)

Copy link
Collaborator

@Finii Finii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, with the bigger icon 👍

It has some double-node still, but that will be removed by fontforge

image

You can see this because one 'path direction' indicator is directly on the node; the indicators are always in the middle of a path, so there must be a zero length path at that node.

In fact you can just remove it, and the shape will not change; or use the join points tool in Inkscape:

image
Small indicator directly on node

image
Select both nodes and push that button

(We can merge as is, I am sure we have plenty of these in several icons anyhow)

@Finii
Copy link
Collaborator

Finii commented Oct 28, 2024

Hej @hasecilu

I will merge this now.
What about Nobara, there were no comments, no thumbsups, merge or not merge?

I ask because I would like to release a new Font Logos version, what do you think? (Because Nerd Fonts' release is overdue already)

@Finii Finii merged commit e31bcd9 into master Oct 28, 2024
@Finii
Copy link
Collaborator

Finii commented Oct 28, 2024

I ask because I would like to release a new Font Logos version, what do you think?

Just released 😬 Hope this is ok for you, if not we can of course do some amends.

Interestingly most npm people seem to use the very old version, note this is last 7 days stats:

image

@hasecilu
Copy link
Collaborator Author

Of course is totally OK.

Maybe was marked as dependency with that tag version?

@hasecilu hasecilu deleted the feat/river_wm branch October 28, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants