Fixed an issue dropping with out placeholder #736
Conversation
|
Hey @alsundukov thanks for the PR, I added a question. Can you also please rebase the PR? Would it be possible to include this in the tests, so that we do note have a decrease in coverage? Thank you. |
|
Hey @lukasoppermann, I did it |
|
Hey @alsundukov great, thank you. Can you please also reply / act on the two comments I added in the review? Thanks |
|
Sure, but I don't see your questions, sorry |
src/html5sortable.ts
Outdated
| // remove placeholder from dom | ||
| visiblePlaceholder.remove() | ||
| } else { | ||
| // set the dropped value to 'true' to delete copied dragging at the time of 'dragend' |
There was a problem hiding this comment.
@alsundukov you write set to true but you are setting it to false, can you explain this?
There was a problem hiding this comment.
ops, this is a typo in the comment
docs/html5sortable.js
Outdated
| insertAfter(visiblePlaceholder, dragging); | ||
| // remove placeholder from dom | ||
| visiblePlaceholder.remove(); | ||
| if (visiblePlaceholder) { |
There was a problem hiding this comment.
Can you please remove this file from the PR, it will be auto-generated on build. Thanks
|
Sorry, it was somehow still pending, you should see it now. |
|
Done |
|
Great, thank you. |
#456
Fixes #456
Similar changes were made in the commit bc04696 Avery Lemons, but all this was in the docs directory