Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #38
Checks that
NO_COLOR
is present to disable the colors. Sorry for missing this in the spec the first time around.@lukeed It might be nice to share this enabled logic between the 2 implementations. I'm unsure how that would affect the bench for kleur.
Also, I noticed that
env.sh
isn't running for tests. I had troubles with getting it to fail with the old logic or the new logic. I instead ranNO_COLOR= yarn test
to see if it was disabling the colors and it appeared to work.