Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add opts.fileRegex option to ignore files in migrations dir #42

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

karlhorky
Copy link
Contributor

@karlhorky karlhorky commented Sep 4, 2024

Hi @lukeed 👋 Hope things are good with you!

I'm playing around with colocating other TypeScript files in the migrations directory, and would love for those files to stay out of the migrations database.

What do you think about the opts.fileRegex approach in this PR, which allows users to customize the regular expression used in the totalist filter?

@karlhorky
Copy link
Contributor Author

Seems like the GitHub Actions actions/setup-node@v1 step is failing, unable to find the requested Node.js version:

Run actions/setup-node@v1
  with:
    node-version: 14
    always-auth: false
Error: Unable to find Node version '14' for platform darwin and architecture arm64.

Screenshot 2024-09-04 at 11 50 37

I think this may be as a result of macos-latest now running on the M1 chips... I'll take a look.

@karlhorky
Copy link
Contributor Author

karlhorky commented Sep 4, 2024

Ok, switching to macos-latest-large (latest runner with the x86_64 arch) failed, I'm thinking it's because large runners would need to be enabled, which is likely unwanted because they cost money IIUC:

Screenshot 2024-09-04 at 11 57 26

Switching to macos-13 is working though, done in c92c5a0

(an alternative would be to update the Node.js versions in the test matrix to only test versions that are available with Darwin arm64, happy to do that if preferred)

@karlhorky
Copy link
Contributor Author

Also upgraded to actions/checkout@v4 and actions/setup-node@v4:

@karlhorky karlhorky marked this pull request as draft September 4, 2024 11:05
@karlhorky karlhorky marked this pull request as ready for review September 4, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant