feat: add graceful shutdown support, returning UndertowWrapper object #34
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #33
Note: this is a breaking change in Java-land, since the object returned is an UndertowWrapper class and not an Undertow class. We sadly cannot proxy Undertow as it is final. An interface or other delegation doesn't work for the same reason.
The option here is to create a wrapper class that exposes all the public methods from Undertow as the same. However, since Undertow is public we still cannot cast to it. As a result, we add a new method
getUndertow
which returns the original object.Projects which use this lib and don't check explicitly for the class match should be unaffected so I think it is a low risk breaking change.