Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove the executable permission bit from some source files #434

Merged
merged 1 commit into from
Jun 29, 2024
Merged

chore: Remove the executable permission bit from some source files #434

merged 1 commit into from
Jun 29, 2024

Conversation

uudiin
Copy link
Contributor

@uudiin uudiin commented Jun 28, 2024

No description provided.

alerque
alerque reviewed Jun 28, 2024
View reviewed changes
Copy link
Member

@alerque alerque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this and taking the time to contribute. This looks quite reasonable for most of the files, but shouldn't the *.cmd and *.bat files still be marked as executable?

@Tieske
Copy link
Member

Tieske commented Jun 29, 2024

That flag has no relevance on Windows. So this should be good to go.

@alerque alerque merged commit 1fad162 into lunarmodules:master Jun 29, 2024
19 checks passed
@uudiin uudiin deleted the permsfix branch July 1, 2024 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alerque alerque alerque approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@uudiin @Tieske @alerque